Make MeshTools::n_connected_components() much faster#4449
Open
roystgnr wants to merge 5 commits intolibMesh:develfrom
Open
Make MeshTools::n_connected_components() much faster#4449roystgnr wants to merge 5 commits intolibMesh:develfrom
roystgnr wants to merge 5 commits intolibMesh:develfrom
Conversation
Not fast enough yet, but 2.5x improvement is a start.
This is faster, though not by as much as I'd hoped.
This is orders of magnitude faster than merging larger into smaller.
This is usually correct, which means we only do the linear search through other components 1/4 of the time and we run 4x faster.
I think we still have room for another OOM improvement on typical multi-million-element problems here, and this output would be helpful for getting runs on those under a second, but now I'm getting results in seconds rather than in hours and that's good enough for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly just an analysis tool I was using to verify some Flex IGA meshes, it's just that it was supposed to be so fast in general that I could just throw it in the calculator app and forget about it, and it turned out that it wasn't.
This is still taking seconds on an interestingly-ordered multimillion-element mesh, when it should be taking fractions of a second, but it used to be taking hours, so I'm stopping here for now and calling it a win. Now it's at least faster than a calculator solve.