Build apps, too, when building in oprof#4447
Open
roystgnr wants to merge 2 commits intolibMesh:develfrom
Open
Conversation
Usually when we're profiling we have an actual application to profile with, but I just caught a performance bug *with* one of our helper apps, and in hindsight there are lots of I/O etc. that's well exercised by things like the calculator app. Building these when we're profiling is probably worth the extra bit of compiling+linking time.
jwpeterson
approved these changes
May 5, 2026
Member
jwpeterson
left a comment
jwpeterson
left a comment
There was a problem hiding this comment.
I don't love that we have to remember to manually update the top-level Makefile.am every time we add a new app (?) but fixing that is a problem for another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually when we're profiling we have an actual application to profile with, but I just caught a performance bug with one of our helper apps, and in hindsight there are lots of I/O etc. that's well exercised by things like the calculator app.
Building these when we're profiling is probably worth the extra bit of compiling+linking time.