Skip to content

Kokkos support for Lagrange and Monomial elements #4441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rochi00 wants to merge 23 commits into
base: devel
Choose a base branch
from
Open

Kokkos support for Lagrange and Monomial elements #4441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c0e8657
Add Kokkos FE math support as optional libMesh dependency
Apr 7, 2026
c1eb62e
Fix 3D MONOMIAL basis ordering and add topology-based nativeShape ove…
Apr 9, 2026
24be7bd
Update Kokkos FE test files for new GPU API (no wrapper enums)
rochi00 Apr 15, 2026
9026f1c
Fix Kokkos build: empty fe_types.C and fix TESTS assignment in tests/…
rochi00 Apr 16, 2026
36be3f7
Disable Kokkos half-precision in test files to fix CUDA build
rochi00 Apr 21, 2026
456ea05
Add device-callable Gauss quadrature to gpu/ headers
rochi00 Apr 22, 2026
1dc4dd1
Update MetaPhysicL submodule: point to upstream bootstrapped branch (…
rochi00 Apr 27, 2026
1c43e29
Address PR review: include guards, snake_case, FEShapeKey refactor, d…
rochi00 Apr 28, 2026
230b4f0
Extract shared quadrature data into quadrature_gauss_data.h
rochi00 Apr 28, 2026
78d8f28
Inline Gauss data and expand Kokkos FE test coverage
rochi00 Apr 30, 2026
4c796ec
Update TIMPI submodule: bootstrapped HEAD with master merge (4aaf0ce)
rochi00 Apr 30, 2026
8c6c5ca
Re-bootstrap
rochi00 Apr 30, 2026
66d23e5
Reorganize Kokkos FE tests around CPU oracle pattern
rochi00 Apr 30, 2026
4987193
Re-bootstrap
rochi00 Apr 30, 2026
4753a28
Refactor Kokkos FE test dispatch helpers
rochi00 May 4, 2026
c3d5892
Add GPU debug output to Kokkos oracle tests
rochi00 May 4, 2026
f4882b9
Make vector and tensor math device-safe
rochi00 May 4, 2026
a718a29
Instrument Kokkos vector oracle normalization
rochi00 May 4, 2026
d9d4bfc
Make tensor helper norms device-safe
rochi00 May 4, 2026
e02e280
Remove Kokkos oracle debug output
rochi00 May 4, 2026
f263d7a
Refactor Kokkos FE code for dimension-aware numerics
rochi00 May 4, 2026
0b9e7d4
Make Kokkos numerics oracles dimension-aware
rochi00 May 5, 2026
639e20b
Isolate Kokkos numerics oracles from FE inputs
rochi00 May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[submodule "contrib/metaphysicl"]
path = contrib/metaphysicl
url = ../../libMesh/MetaPhysicL
url = ../../rochi00/MetaPhysicL
Copy link
Copy Markdown
Member

@roystgnr roystgnr Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Definitely not.

[submodule "contrib/timpi"]
path = contrib/timpi
url = ../../libMesh/TIMPI
Expand Down
6 changes: 6 additions & 0 deletions Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,12 @@ SUBDIRS += contrib

include src/libmesh_SOURCES

# When Kokkos support is enabled, add the Kokkos FE type-conversion sources.
# These are kept in src/kokkos/ and not in src/libmesh_SOURCES (which is
# auto-generated) so that they don't affect non-Kokkos builds.
if LIBMESH_ENABLE_KOKKOS
endif
Comment on lines +263 to +264
Copy link
Copy Markdown
Member

@roystgnr roystgnr Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, one more comment.

There's an interesting story about the rock band Van Halen:

When they were on tour, they had a fairly complicated and safety-critical set of contract stipulations that venues had to meet: heavy platforms and heavy equipment, serious electrical requirements, pyrotechnics, etc. And they had a little contract clause that demanded a bowl of M&Ms for them backstage, with all the brown M&Ms removed.

If someone challenged that clause, they waived it. They didn't care about not eating brown M&Ms. They just cared that the big long critical pile of contract text had actually been respected, entirely read by the people with the primary responsibility of reading it and making sure everything was set up correctly. If they hadn't been reading carefully enough to notice the brown-M&M-hating-divas bit, could they really be trusted to be getting the subtle, tricky mechanical and electrical and thermal stuff done and inspected safely? No; the band roadies would essentially have to reinspect everything to see which parts of it they'd have to redo.

It was not a good idea to be a venue that made the hard rock band and their annoyed roadies unable to trust any of your work.

Copy link
Copy Markdown
Author

@rochi00 rochi00 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I mostly paid attention to the tests that were written, and once they all passed assumed the internal code was correct. That was clearly not a good idea. I will review everything now. The tests clearly didn't have enough coverage

Copy link
Copy Markdown
Author

@rochi00 rochi00 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The claude generated comments had so many issues, it is terrifying how much it overclaims


# A convenience library to hold proper libMesh
# objects. This will get appended with any contributed
# sources to create the final library.
Expand Down
12 changes: 12 additions & 0 deletions Makefile.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7517,11 +7517,18 @@ HDF5_DIR = @HDF5_DIR@
HDF5_LDFLAGS = @HDF5_LDFLAGS@
HDF5_LIBS = @HDF5_LIBS@
HDF5_PREFIX = @HDF5_PREFIX@
HIPCC = @HIPCC@
ICPX = @ICPX@
INSTALL = @INSTALL@
INSTALL_DATA = @INSTALL_DATA@
INSTALL_PROGRAM = @INSTALL_PROGRAM@
INSTALL_SCRIPT = @INSTALL_SCRIPT@
INSTALL_STRIP_PROGRAM = @INSTALL_STRIP_PROGRAM@
KOKKOS_CPPFLAGS = @KOKKOS_CPPFLAGS@
KOKKOS_CXX = @KOKKOS_CXX@
KOKKOS_CXXFLAGS = @KOKKOS_CXXFLAGS@
KOKKOS_LDFLAGS = @KOKKOS_LDFLAGS@
KOKKOS_LIBS = @KOKKOS_LIBS@
LASPACK_INCLUDE = @LASPACK_INCLUDE@
LASPACK_LIB = @LASPACK_LIB@
LD = @LD@
Expand Down Expand Up @@ -7569,6 +7576,7 @@ NODEPRECATEDFLAG = @NODEPRECATEDFLAG@
NOX_INCLUDES = @NOX_INCLUDES@
NOX_LIBS = @NOX_LIBS@
NOX_MAKEFILE_EXPORT = @NOX_MAKEFILE_EXPORT@
NVCC = @NVCC@
NVTX_INCLUDE = @NVTX_INCLUDE@
OBJDUMP = @OBJDUMP@
OBJEXT = @OBJEXT@
Expand Down Expand Up @@ -8340,6 +8348,10 @@ libmesh_SOURCES = \
src/utils/xdr_cxx.C


# When Kokkos support is enabled, add the Kokkos FE type-conversion sources.
# These are kept in src/kokkos/ and not in src/libmesh_SOURCES (which is
# auto-generated) so that they don't affect non-Kokkos builds.

# A convenience library to hold proper libMesh
# objects. This will get appended with any contributed
# sources to create the final library.
Expand Down
Loading