Don't require CommandComplete or EmptyQueryResponse in simpleQuery() #1234
+173
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it would panic if a ReadyForQuery was sent without a CommandComplete or EmptyQueryResponse. Not sure when/how this happens because as I understand the protocol technically this Shouldn't Happen™. I had a bit of a look at how libpq handles this, and it doesn't require this either: it just handles any response (if any) And prepares for a new query. So probably okay to do the same here. Also add pqtest.Fake() to more easily test this sort of thing. Closes #1230 Fixes #1059 Fixes #1173 Co-authored-by: yowgf <alexthomasmol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would panic if a ReadyForQuery was sent without a CommandComplete or EmptyQueryResponse.
Not sure when/how this happens because as I understand the protocol technically this Shouldn't Happen™. I had a bit of a look at how libpq handles this, and it doesn't require this either: it just handles any response (if any) And prepares for a new query. So probably okay to do the same here.
Also add pqtest.Fake() to more easily test this sort of thing.
Closes #1230
Fixes #1059
Fixes #1173