database inspector changes: removed filter route (commented) #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
why is that? |
Member
Author
|
We decided to remove it and handle the logic on the frontend. |
Contributor
|
As you wish |
| example: ">=" | ||
| value: | ||
| example: 2 | ||
| # FilterDataRequest: |
There was a problem hiding this comment.
commenting out the specs is not aligned with clean code ! the spec should reflect the client<>server contract. if this part of contract has been removed or not exists any more, it's better to remove it completely, otherwise suggest to keep it as it is.
btw the PR title reflects the removed filter but the content of PR comments some lines! they are not aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.