Finalize native EVMYulLean proof boundary cleanup#1924
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
| \n### CI Failure Hints\n\nFailed jobs: `checks`\n\nCopy-paste local triage:\n```bash\nmake check\nlake build\nFOUNDRY_PROFILE=difftest forge test -vv\n``` |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bf4d0d5. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
EvmYulLeanNativeLowering.lean/EvmYulLeanNativeHarness.leanselfBalanceas a partially modeled runtime-introspection boundary and reject it under--deny-runtime-introspectionuntil the native account-balance bridge is provedthrow s!"..."branches, including inlinefuncDef, are reported instead of silently treated as completeValidation
lake env lean Compiler/Proofs/YulGeneration/Backends/EvmYulLeanBuiltinSemantics.leanlake env lean Compiler/Proofs/YulGeneration/Backends/EvmYulLeanBridgeLemmas.leanlake env lean Compiler/Proofs/YulGeneration/Backends/EvmYulLeanBridgeTest.leanlake env lean Compiler/Proofs/YulGeneration/Backends/EvmYulLeanNativeLowering.leanlake env lean Compiler/Proofs/YulGeneration/Backends/EvmYulLeanNativeHarness.leanlake env lean Compiler/Proofs/EndToEnd.leanlake env lean PrintAxioms.leanlake build Compiler.CompileDriverTestlake build Compilerpython3 -m unittest scripts/test_generate_evmyullean_adapter_report.py scripts/test_evmyullean_fork_conformance_workflow.py scripts/test_check_yul.py scripts/test_evmyullean_capability.py -vpython3 scripts/generate_evmyullean_capability_report.py --checkmake checkAudit Notes
EvmYulLeanAdapter,evalBuiltinCallWithBackend,ReferenceOracle,reference oracle,proof-interpreter, and custom-Yul wording across live source, docs, scripts, workflows, and artifactsPrintAxioms.leannow reports5162theorems/lemmas and0 sorry'dfuncDefstatement lowering as a partial native lowering boundary; top-level runtimefuncDefpartitioning remains supported bylowerRuntimeContractNativeNote
Medium Risk
Medium risk because it removes/renames core proof-boundary components (adapter/backend wrapper) and retargets CI/artifacts to the native lowering path; mistakes could silently weaken conformance checks or break proof builds.
Overview
Finalizes the native EVMYulLean-only proof boundary by deleting the legacy structural adapter (
EvmYulLeanAdapter.lean), collapsing the one-constructorBuiltinBackend/evalBuiltinCallWithBackend*indirection into directevalBuiltinCallWithEvmYulLeanContext, and renaming error plumbing fromAdapterErrortoNativeLoweringErroracross the native harness and EndToEnd theorem surface.Updates trust-surface reporting to treat
Expr.selfBalanceas partially modeled runtime introspection (with new compile-driver tests that ensure--deny-runtime-introspectionfails closed), and trims now-dead bridge lemmas/references from proof inventories.Retargets CI/workflows, scripts, tests, and generated artifacts/documentation from “adapter” coverage to native lowering coverage (
EvmYulLeanNativeLowering.lean/EvmYulLeanNativeHarness.lean), including improved gap detection that recognizesthrow s!"..."branches and reportingfuncDefas a native lowering gap in the capability/unsupported-node reports.Reviewed by Cursor Bugbot for commit 5fbf9b5. Bugbot is set up for automated code reviews on this repo. Configure here.
Fixes #1836.