Replace log package with fully slog-based system #8606
Draft
+273
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcpherrinm
reviewed
Jan 28, 2026
|
|
||
| import "log/slog" | ||
|
|
||
| func AcctAttr(acctID int) slog.Attr { |
Contributor
There was a problem hiding this comment.
If these were in a package attr, you could invoke them as attr.Acct()
Contributor
Author
There was a problem hiding this comment.
Yeah, the thought occurred to me, but I'm not sure that a type name that is shorter but doesn't include the word "log" is really worth it. Could go either way.
Contributor
There was a problem hiding this comment.
I'm inclined to go with the package name attr.Acct() (these will always and only show up in the context of a log line). Though there's a third contender: log.Acct(). Or in practice blog.Acct() since we usually rename this import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This is a work in progress. Not ready for real review, but open to structural feedback.
Fixes #8557