Reduce cardinality of structured log keys #8600
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
approved these changes
Jan 27, 2026
jsha
requested review from
a team and
beautifulentropy
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine the certificateRequestEvent's Identifiers field (a list of idents) and its Authorizations field (a map of identifiers to authz metadata) into a list of structs which contain both an identifier and authorization metadata. This prevents our structured JSON logs from having high-cardinality keys. It also reduces duplicate information by not listing each identifier twice. The new sub-structure also contains the time at which the authorization was validated, which can be very useful for identifying affected issuance during a mass revocation event.
Fixes #8571