sa: collapse migrations into CombinedSchema #8599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
aarongable
approved these changes
Jan 26, 2026
Contributor
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
LGTM, diff looks good, and comparison against actual prod schema looks good too.
Contributor
Author
|
BTW, bot, the SQL changes simply align with existing production config, but thanks for checking in. |
beautifulentropy
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it a little easier / simpler to look to our CombinedSchema for an approximation of the final schema. This uses a dump from the production DB, so it aligns some small details that are different but not that important (like charset, and the ordering of indexes in the CREATE statement).