Deprecate ServeRenewalInfo feature flag #8585
Merged
+11
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
requested changes
Jan 21, 2026
added 5 commits
January 21, 2026 19:16
aarongable
previously approved these changes
Jan 21, 2026
jsha
reviewed
Jan 27, 2026
features/features.go
Outdated
Comment on lines
36
to
38
| // ServeRenewalInfo exposes the renewalInfo endpoint in the directory and for | ||
| // GET requests. WARNING: This feature is a draft and highly unstable. | ||
| ServeRenewalInfo bool |
jsha
reviewed
Jan 27, 2026
Contributor
jsha
left a comment
jsha
left a comment
There was a problem hiding this comment.
Generally looks good other than that one fix. Thanks!
Contributor
Author
Great. Apologies about that. Was a bad merge on my part |
aarongable
approved these changes
Jan 27, 2026
jsha
approved these changes
Jan 27, 2026
Contributor
|
Thanks for this contribution! For future reference, no need to merge main at the very end, unless an actual merge conflict has shown up. |
aarongable
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8341
IN-8593 tracked the corresponding prod config change