chore: add test for number with underscore parsing#4374
Closed
Krinkle wants to merge 1 commit intoless:masterfrom
Closed
chore: add test for number with underscore parsing#4374Krinkle wants to merge 1 commit intoless:masterfrom
Krinkle wants to merge 1 commit intoless:masterfrom
Conversation
In Less.js 2.6.0, parsing of dimensions changed so that `5_large` is seen as one value, instead of as a list containing "5" and "_large". In updating the Less.php port, we forgot to consider this change because none of the Less.js 3.13 tests seem to cover this behavior. Follows-up less#2485. This adds the test case from less#2462, as inpired by downstream https://gerrit.wikimedia.org/r/1197310.
dosubot
Bot
added
the
size:XS
Contributor
puckowski
reviewed
Oct 28, 2025
| } | ||
| }) | ||
|
|
||
| // https://github.com/less/less.js/issues/2462 |
Contributor
There was a problem hiding this comment.
It is good information, though I prefer to drop the comment with issue number as the comment itself is not used as part of the test.
matthew-dean
approved these changes
Mar 8, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Add the test case from #2462, as inpired by downstream https://gerrit.wikimedia.org/r/1197310.
Why:
Follows-up #2485.
In Less.js 2.6.0, parsing of dimensions changed so that
5_largeis seen as one value, instead of as a list containing "5" and "_large".In maintaining the wikimedia/less.php port, I recently found that we never applied this change because none of the Less.js 3.13 tests covered this behavior.
Checklist: