Skip to content

chore: fix inconsistent version #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leotrinh merged 2 commits into from
Mar 5, 2026
Merged

chore: fix inconsistent version #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77368f8
chore: fix inconsistent version
leotrinh Mar 5, 2026
959e2a4
feat: version base on pkg
leotrinh Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"use strict";

/** Library Version */
module.exports.version = "1.0.7";
/** Library Version — read dynamically from package.json */
module.exports.version = require("./package.json").version;

// ── Cloud Controller models ────────────────────────────────────────────
const Apps = require("./lib/model/cloudcontroller/Apps");
Expand Down
14 changes: 9 additions & 5 deletions test/lib/ApiMigrationTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ const CloudController = require('../../lib/model/cloudcontroller/CloudController
const ApiConfig = require('../../lib/config/ApiConfig');
const ApiVersionManager = require('../../lib/config/ApiVersionManager');

describe('cf-node-client v1.0.6 - API v3 Migration', function () {
// Dynamically read version from package.json to avoid manual updates
const pkg = require('../../package.json');
const expectedVersion = pkg.version;

describe(`cf-node-client v${expectedVersion} - API v3 Migration`, function () {
this.timeout(5000);

describe('Package Configuration', function () {
Expand All @@ -20,14 +24,14 @@ describe('cf-node-client v1.0.6 - API v3 Migration', function () {
expect(pkg.name).to.equal('cf-node-client');
});

it('should have version 1.0.6', function () {
it('should have version from package.json', function () {
const pkg = require('../../package.json');
expect(pkg.version).to.equal('1.0.6');
expect(pkg.version).to.equal(expectedVersion);
});

it('should have index.js export version 1.0.6', function () {
it('should have index.js export version from package.json', function () {
const lib = require('../../index.js');
expect(lib.version).to.equal('1.0.6');
expect(lib.version).to.equal(expectedVersion);
});

it('should export all 16 Cloud Foundry models', function () {
Expand Down