Skip to content

windows-rocm: enable GGML_HIP so ggml-hip.dll actually gets built #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyfowers merged 5 commits into from
May 16, 2026
Merged

windows-rocm: enable GGML_HIP so ggml-hip.dll actually gets built #3

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f0b227
windows-rocm: enable GGML_HIP and verify ggml-hip.dll was built
jeremyfowers May 15, 2026
b65b264
windows-rocm: add -DGGML_CPU_ALL_VARIANTS=ON so the CPU backend ships
jeremyfowers May 15, 2026
d6d8dbb
windows-rocm: flip GGML_CPU=ON so per-microarch variants compile
jeremyfowers May 16, 2026
380c908
windows-rocm: silence -Werror=incompatible-pointer-types on x86 CPU q…
jeremyfowers May 16, 2026
e6452b5
windows-rocm: drop deprecated -DGPU_TARGETS in favor of -DAMDGPU_TARGETS
jeremyfowers May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,16 +234,30 @@ jobs:
-DCMAKE_BUILD_TYPE=Release `
-DGGML_BACKEND_DL=ON `
-DGGML_NATIVE=OFF `
-DGGML_CPU=OFF `
-DGGML_CPU=ON `
-DGGML_CPU_ALL_VARIANTS=ON `
-DGGML_HIP=ON `
-DCMAKE_C_COMPILER="${env:HIP_PATH}\lib\llvm\bin\clang.exe" `
-DCMAKE_CXX_COMPILER="${env:HIP_PATH}\lib\llvm\bin\clang++.exe" `
-DCMAKE_C_FLAGS="-Wno-error=incompatible-pointer-types" `
-DCMAKE_HIP_COMPILER="${env:HIP_PATH}\lib\llvm\bin\clang.exe" `
-DHIP_PATH="${env:HIP_PATH}" `
-DCMAKE_BUILD_TYPE=Release `
Copy link
Copy Markdown
Member

@superm1 superm1 May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want a release build?

Copy link
Copy Markdown
Member Author

@jeremyfowers jeremyfowers May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is still Release — -DCMAKE_BUILD_TYPE=Release is still set at line 234 just above (the original had it twice; I deduped). And cmake --build . --config Release --parallel ... on the next line reinforces it for multi-config generators. So no behavior change here, just dropping the duplicate.

-DGGML_HIP_ROCWMMA_FATTN=ON `
-DGPU_TARGETS="${{ matrix.gpu_targets }}"
-DAMDGPU_TARGETS="${{ matrix.gpu_targets }}"
cmake --build . --config Release --parallel ${env:NUMBER_OF_PROCESSORS}

- name: Verify HIP backend was built
run: |
$hipDll = Get-ChildItem -Path build\bin -Filter "ggml-hip*.dll" -ErrorAction SilentlyContinue
if (-not $hipDll) {
Write-Host "##[error]ggml-hip*.dll was NOT produced. The HIP backend silently failed to build."
Write-Host "Contents of build\bin:"
Get-ChildItem build\bin | Format-Table -AutoSize
exit 1
}
Write-Host "HIP backend artifact found:"
$hipDll | Format-Table FullName, Length -AutoSize

- name: Determine tag name
id: tag
uses: lemonade-sdk/llama.cpp/.github/actions/get-tag-name@lemonade
Expand Down
Loading