Skip to content

Conversation

@LuridHound
Copy link
Contributor

No description provided.

@LuridHound
Copy link
Contributor Author

erroneously created previous PR on master - thus current changes are expecting that PR to be merged - after this additional lines will go away.
talking about - #1035

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request modernizes type casting in the codebase by replacing C-style casts with C++ static_cast, which provides better type safety and makes type conversions more explicit. The changes address "issue 1000" which likely pertains to adopting modern C++ casting conventions.

Key Changes:

  • Converted C-style casts (type)value to static_cast<type>(value) throughout xmltest.cpp for integer and double conversions
  • Removed an unnecessary static_cast<int> in tinyxml2.cpp where size_t to size_t conversion was already correct

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
xmltest.cpp Converted all C-style casts to static_cast for timing calculations, attribute type conversions, and test assertions
tinyxml2.cpp Removed unnecessary cast from size_t to int in XMLPrinter::Write, as PushArr expects size_t directly

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leethomason leethomason merged commit c4e29af into leethomason:master Nov 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants