Skip to content

Convert accessibility options unit tests to Vue Testing Library #5794#5889

Open
LightCreator1007 wants to merge 3 commits intolearningequality:unstablefrom
LightCreator1007:convert-accessibilityOptions-unit-tests-to-vtl
Open

Convert accessibility options unit tests to Vue Testing Library #5794#5889
LightCreator1007 wants to merge 3 commits intolearningequality:unstablefrom
LightCreator1007:convert-accessibilityOptions-unit-tests-to-vtl

Conversation

@LightCreator1007
Copy link
Copy Markdown
Contributor

Summary

  • Migrated to vue-testing-library.
  • Adhered to VTL's query priorities whenever and wherever possible (example: using getByRole instead of getByTestId).
  • Added new user-interaction test, to explicitly test the checking and uncjecing of options and verifying v-model emissions.
Screenshot From 2026-05-09 21-03-05
Screencast.From.2026-05-09.20-37-55.mp4

References

Closes #5794

Reviewer guidance

  • Run

    pnpm test channelEdit/components/edit/__tests__/accessibilityOptions.spec.js

    to test whether all 10 tests are passing or not.

  • Note on Tooltips: Tooltip elements currently seem to render as SVGs inside spans . So i thought of falling back to using getByTestId for the tooltip assertions.

AI usage

Code was adjusted, troubleshot and tested for bugs iteratively in collaboration with gemini and claude. Reviewed and audited to the best of my abilites to ensure integrity and correctness of code.

- covered all the original tests.
- coverage includes user interaction tests.
@learning-equality-bot
Copy link
Copy Markdown

👋 Hi @LightCreator1007, thanks for contributing!

For the review process to begin, please verify that the following is satisfied:

  • Contribution is aligned with our contributing guidelines

  • Pull request description has correctly filled AI usage section & follows our AI guidance:

    AI guidance

    State explicitly whether you didn't use or used AI & how.

    If you used it, ensure that the PR is aligned with Using AI as well as our DEEP framework. DEEP asks you:

    • Disclose — Be open about when you've used AI for support.
    • Engage critically — Question what is generated. Review code for correctness and unnecessary complexity.
    • Edit — Review and refine AI output. Remove unnecessary code and verify it still works after your edits.
    • Process sharing — Explain how you used the AI so others can learn.

    Examples of good disclosures:

    "I used Claude Code to implement the component, prompting it to follow the pattern in ComponentX. I reviewed the generated code, removed unnecessary error handling, and verified the tests pass."

    "I brainstormed the approach with Gemini, then had it write failing tests for the feature. After reviewing the tests, I used Claude Code to generate the implementation. I refactored the output to reduce verbosity and ran the full test suite."

Also check that issue requirements are satisfied & you ran pre-commit locally.

Pull requests that don't follow the guidelines will be closed.

Reviewer assignment can take up to 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert accessibility options unit tests to Vue Testing Library

1 participant