Skip to content

Fix duplicate community library submission #5773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexVelezLl wants to merge 1 commit into
base: unstable
Choose a base branch
from
+11 −3
Open

Fix duplicate community library submission #5773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...ration/contentcuration/frontend/shared/composables/useLatestCommunityLibrarySubmission.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ export function useLatestCommunityLibrarySubmission({ channelId, admin = false }

function fetchLatestSubmission() {
// Submissions are ordered by most recent first in the backend
return Resource.fetchCollection({ channel: channelId, max_results: 1 }).then(response => {
return Resource.fetchCollection({
channel: channelId,
max_results: 1,
ordering: '-date_created',
}).then(response => {
if (response.results.length > 0) {
return response.results[0];
}
Expand Down
8 changes: 6 additions & 2 deletions contentcuration/contentcuration/viewsets/community_library_submission.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from contentcuration.viewsets.base import RESTCreateModelMixin
from contentcuration.viewsets.base import RESTDestroyModelMixin
from contentcuration.viewsets.base import RESTUpdateModelMixin
from contentcuration.viewsets.base import ValuesViewsetOrderingFilter
from contentcuration.viewsets.common import UserFilteredPrimaryKeyRelatedField
from contentcuration.viewsets.sync.utils import (
generate_added_to_community_library_event,
Expand Down Expand Up @@ -244,12 +245,15 @@ class CommunityLibrarySubmissionViewSetMixin:
"resolved_by_name": get_resolved_by_name,
"channel_name": lambda item: item.get("channel__name"),
}
queryset = CommunityLibrarySubmission.objects.all().order_by("-date_updated")
filter_backends = [DjangoFilterBackend, SearchFilter]
queryset = CommunityLibrarySubmission.objects.all()
filter_backends = [DjangoFilterBackend, SearchFilter, ValuesViewsetOrderingFilter]
filterset_class = CommunityLibrarySubmissionFilterSet
search_fields = ["channel__name"]
pagination_class = CommunityLibrarySubmissionPagination

ordering_fields = ["date_updated", "date_created"]
ordering = "-date_updated"
Copy link
Contributor

@rtibblesbot rtibblesbot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Good design — setting ordering = "-date_updated" as the viewset default preserves backward compatibility for all other callers while enabling the frontend to override with -date_created when needed.


def consolidate(self, items, queryset):
countries = {}
for (submission_id, country_code,) in Country.objects.filter(
Expand Down
Loading