Community channels page by AlexVelezLl · Pull Request #5770 · learningequality/studio

AlexVelezLl · 2026-03-20T13:06:26Z

Summary

Adds new Community Channels List page.
Adds a new tab on the channelsList plugin.
Adapts response from public models to match the expected formats of existing components.
Updates public v2 channel metadata viewset to allow search and filter by languages, and page-based pagination. Also, returned channel version tokens, in case a specific public version has a token.
Updates useFilter composable to support multi-value select filters.
For now, I have just listed all possible values for countries, categories, and languages, but we can filter these down in a follow-up. Also, we will probably need some sort of "welcome page" or hide this tab until we have community library channels.

Grabacion.de.pantalla.2026-03-20.a.la.s.8.03.42.a.m.mov

Reviewer guidance

Make sure you have approved community channels.
On the main channels page, look at the new "Community Library" tab.
Play with filters and search.
Make sure that cards don't break with these new community channels.

AI usage

Used AI to set up the initial scaffold of the new router page, but ended up refactoring almost everything since it didn't do a good job following most up-to-date development patterns in our repo.

marcellamaki · 2026-03-20T13:13:09Z

ended up refactoring almost everything since it didn't do a good job following most up-to-date development patterns in our repo

💀

rtibblesbot

Solid new feature adding a Community Library browsing page with filters, search, pagination, and channel details. The architecture is clean — good use of provide/inject for filter state, backward-compatible pagination, and proper deduplication for M2M joins.

CI passing (relevant checks skipped due to path matching).

Suggestions:

Stray > after </script> in AboutCommunityLibraryModal.vue
Unused nResultsFound i18n string (duplicate of resultsText)
Debug print left in test
Country span renders with dot separator even when countries array is empty
Duplicate mapResponseChannel across two files

See inline comments for details.

Comments on lines not in diff:

contentcuration/kolibri_public/views.py:209 — praise: The existing deduplication via OrderedDict neatly handles potential duplicates from the M2M included_languages filter join. Good that this was already in place.

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Reviewed the pull request diff checking for:

Correctness: bugs, edge cases, undocumented behavior, resource leaks, hardcoded values
Design: unnecessary complexity, naming, readability, comment accuracy, redundant state
Architecture: duplicated concerns, minimal interfaces, composition over inheritance
Testing: behavior-based assertions, mocks only at hard boundaries, accurate coverage
Completeness: missing dependencies, unupdated usages, i18n, accessibility, security
Principles: DRY (same reason to change), SRP, Rule of Three (no premature abstraction)
Checked CI status and linked issue acceptance criteria
For UI changes: inspected screenshots for layout, visual completeness, and consistency

rtibblesbot · 2026-03-20T14:39:40Z

...ation/frontend/channelList/views/Channel/CommunityLibraryList/AboutCommunityLibraryModal.vue

+  } = communityChannelsStrings;
+
+</script>
+>


suggestion: There's a stray > character after the closing </script> tag. Vue SFC parsers will likely ignore it, but it should be removed to keep the file clean.

Thanks, good catch

rtibblesbot · 2026-03-20T14:39:40Z

contentcuration/contentcuration/frontend/shared/strings/communityChannelsStrings.js

+  searchLabel: {
+    message: 'Search',
+    context: 'Label for the search input',
+  },


suggestion: nResultsFound appears to be an unused duplicate of resultsText (defined a few lines above). Only resultsText is referenced in the template. Consider removing nResultsFound to avoid confusion. They also use different ICU plural syntax (=1 vs one).

Great catch, thanks.

rtibblesbot · 2026-03-20T14:39:40Z

contentcuration/kolibri_public/tests/test_channelmetadata_viewset.py

+        response = self._list({"languages": "en,fr", "public": "false"})
+        self.assertEqual(response.status_code, 200, response.content)
+        ids = [UUID(item["id"]) for item in response.data]
+        print("ids", ids)


nitpick: Debug print("ids", ids) left in the test. Should be removed before merge.

rtibblesbot · 2026-03-20T14:39:40Z

contentcuration/contentcuration/frontend/channelList/views/Channel/StudioChannelCard/index.vue

          <span>
            {{ language }}
          </span>
+          <span v-if="channel.countries">


suggestion: v-if="channel.countries" is truthy for an empty array []. When the API returns countries: [] (which it does by default in consolidate), this span renders with empty text but still gets the • dot separator from the CSS span:not(:last-child)::after rule. Consider v-if="channel.countries && channel.countries.length" or v-if="country" to avoid the visual artifact.

rtibblesbot · 2026-03-20T14:39:40Z

...ntcuration/contentcuration/frontend/channelList/views/Channel/CommunityLibraryList/index.vue

+  import SidePanelModal from 'shared/views/SidePanelModal';
+  import { commonStrings } from 'shared/strings/commonStrings';
+
+  function mapResponseChannel(channel) {


suggestion: This mapResponseChannel function is nearly identical to the one in CommunityChannelDetailsModal.vue (which has additional fields like resource_count, resource_size, languages, licenses). Consider extracting a shared utility to avoid divergence over time. The details modal version is a superset — the list version could potentially reuse it.

I don't want to mess with it just yet, until we have a clear direction on whether we want to introduce info from the public models on more places.

rtibblesbot · 2026-03-20T14:39:40Z

...ation/frontend/channelList/views/Channel/CommunityLibraryList/useCommunityChannelsFilters.js

@@ -0,0 +1,156 @@
+import { computed, inject, provide } from 'vue';


praise: Clean use of provide/inject with Symbol keys to share filter state between the parent list component and the filters component without prop drilling. The composable pattern with both useCommunityChannelsFilters (provider) and injectCommunityChannelsFilters (consumer) is well-structured.

rtibblesbot · 2026-03-20T14:39:40Z

contentcuration/kolibri_public/views.py



+class ChannelMetadataListPagination(CachedListPagination):
+    page_size = None


praise: Good choice setting page_size = None — this makes pagination opt-in via query param, preserving backward compatibility for existing callers that expect a flat list response.

rtibblesbot · 2026-03-20T14:39:40Z

contentcuration/contentcuration/frontend/shared/composables/useFilter.js

 * @returns {UseFilterReturn}
 */
-export function useFilter({ name, filterMap, defaultValue = null }) {
+export function useFilter({ name, filterMap, multi, defaultValue = null }) {


praise: The multi-select extension to useFilter is well-designed — comma-separated URL params, proper unifyMultiParams merging, and clean integration with existing single-select behavior.

rtibblesbot

Prior findings

Resolved:

Stray > in AboutCommunityLibraryModal.vue (suggestion) — removed in 2720b83
Unused nResultsFound string (suggestion) — removed in 2720b83
Debug print in test (nitpick) — removed in 2720b83
Empty-array truthy check on channel.countries in StudioChannelCard (suggestion) — changed to v-if="country" in 2720b83

Acknowledged (not re-raised):

Duplicate mapResponseChannel (suggestion) — author replied: "I don't want to mess with it just yet"

5/5 prior findings resolved or acknowledged. 0 re-raised.

Clean delta — all prior findings addressed. One new suggestion on StudioDetailsPanel. CI passing.

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Compared the current PR state against findings from a prior review:

Retrieved prior bot reviews deterministically via the GitHub API
Classified each prior finding as RESOLVED, UNADDRESSED, ACKNOWLEDGED, or CONTESTED
Only raised NEW findings for newly introduced code
Reviewed the pull request diff checking for correctness, design, architecture, testing, completeness, and adherence to DRY/SRP principles
Checked CI status and linked issue acceptance criteria

rtibblesbot · 2026-03-20T15:10:57Z

contentcuration/contentcuration/frontend/shared/views/details/StudioDetailsPanel.vue

      </StudioDetailsRow>

+      <StudioDetailsRow
+        v-if="_details.countries"


suggestion: Same empty-array pattern that was just fixed in StudioChannelCard: _details.countries is [] (truthy) for community channels with no countries, so this row renders and ExpandableList receives items=null from the countries computed. Consider v-if="countries" (the computed property) to stay consistent with the StudioChannelCard fix.

rtibblesbot · 2026-03-20T15:10:57Z

contentcuration/kolibri_public/tests/test_channelmetadata_viewset.py

+        self.assertEqual(response.status_code, 200, response.content)
+        ids = [UUID(item["id"]) for item in response.data]
+        self.assertIn(UUID(self.channel_en.id), ids)
+        self.assertNotIn(UUID(self.channel_multi.id), ids)


praise: Thorough test coverage — search, case insensitivity, combined filters, and the language M2M filter are all well-covered with clear setup and assertions.

AlexVelezLl added 4 commits March 20, 2026 09:35

Add community library page on channelslist

86cf30f

About community library

5c162b9

Add Community Channel Details page

bb5d337

Adapt StudioChannelCard and StudioDetailsPanel

b22272c

AlexVelezLl force-pushed the community_channels_page branch from b1bdaf4 to b22272c Compare March 20, 2026 14:35

AlexVelezLl requested a review from rtibblesbot March 20, 2026 14:35

rtibblesbot reviewed Mar 20, 2026

View reviewed changes

Address PR comments

2720b83

rtibblesbot reviewed Mar 20, 2026

View reviewed changes

		@@ -0,0 +1,156 @@
		import { computed, inject, provide } from 'vue';



		class ChannelMetadataListPagination(CachedListPagination):
		page_size = None

Conversation

AlexVelezLl commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Reviewer guidance

AI usage

Uh oh!

marcellamaki commented Mar 20, 2026

Uh oh!

rtibblesbot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rtibblesbot left a comment

Choose a reason for hiding this comment

Prior findings

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AlexVelezLl commented Mar 20, 2026 •

edited

Loading