feat: implement credential controller and routes#47
Merged
3m1n3nc3 merged 2 commits intoMar 9, 2026
Conversation
- Add GET /credentials endpoint for user credentials with filtering and pagination - Add GET /credentials/:id endpoint for single credential details - Add GET /credentials/verify/:onChainId for public verification - Implement comprehensive validation using Zod schemas - Add 14 unit tests with full coverage - Update routes index to include credentials endpoints Closes learnault#8
Contributor
Author
|
@3m1n3nc3 please review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credential Controller & Routes Implementation
Closes #8
Overview
Implements credential management endpoints for certificates and achievements as specified in issue #8.
Changes Made
New Files
src/controllers/credential.controller.ts- Controller with three main endpointssrc/routes/v1/credentials.routes.ts- Route definitions with validationtests/unit/credential.controller.test.ts- Comprehensive unit tests (14 tests, all passing)Modified Files
src/routes/index.ts- Added credentials routes to APIImplemented Endpoints
1. GET /api/v1/credentials
moduleId,fromDate,toDate,page,limit2. GET /api/v1/credentials/:id
3. GET /api/v1/credentials/verify/:onChainId
Technical Details
Validation
Error Handling
Database
Testing
Acceptance Criteria Met
Code Quality