Capacitor 7 #97
Merged
Capacitor 7 #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Capacitor to version 7 and updates related dependencies while ensuring that tests can run correctly in a jsdom environment.
- Updated test setup to include vi for mocking scrollIntoView.
- Modified ESLint configuration to ignore the android directory.
Reviewed Changes
Copilot reviewed 3 out of 11 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/setupTests.ts | Added the vi import and applied a jsdom workaround for scrollIntoView. |
| eslint.config.mjs | Updated global ignores to include the android directory. |
Files not reviewed (8)
- .nvmrc: Language not supported
- android/app/build.gradle: Language not supported
- android/app/capacitor.build.gradle: Language not supported
- android/app/src/main/AndroidManifest.xml: Language not supported
- android/build.gradle: Language not supported
- android/gradle/wrapper/gradle-wrapper.properties: Language not supported
- android/variables.gradle: Language not supported
- package.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Instructions
🔧 Change Summary
List the changes included in this pull request.
📝 Checklist
Pull request authors must complete the following tasks before marking the PR as ready to review.
🧪 Steps to Test
Describe the process to test the changes in this pull request.
🔗 Additional Information
Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.