chore: preserve erased specs through mvcgen' spec DB migration#13897
Merged
Conversation
This PR refactors `mvcgen'` to not drop erased `@[spec]` theorems when migrating the legacy spec database. Erased entries are now copied into the new database and filtered out at lookup time, matching the legacy behavior. `migrateSpecTheoremsDatabase` folds `simpThms.erased` into `database.erased` via the new `SpecProof.ofOrigin` helper. `SpecTheoremsNew.findSpecs` filters matched candidates by the erased set.
sgraf812
force-pushed
the
sg/sym-mvcgen-erased-specs
branch
from
105d624 to
7832649
Compare
Contributor
Author
|
!bench |
|
Benchmark results for 7832649 against 1744bf5 are in. No significant results found. @sgraf812
No significant changes detected. |
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
mvcgen'to not drop erased@[spec]theorems when migrating the legacy spec database. Erased entries are now copied into the new database and filtered out at lookup time, matching the legacy behavior.migrateSpecTheoremsDatabasefoldssimpThms.erasedintodatabase.erasedvia the newSpecProof.ofOriginhelper.SpecTheoremsNew.findSpecsfilters matched candidates by the erased set.