Skip to content

test: lake: avoid git init in the checked-in test tree#13873

Open
Kha wants to merge 1 commit into
leanprover:masterfrom
Kha:push-urrykypuuvyv
Open

test: lake: avoid git init in the checked-in test tree#13873
Kha wants to merge 1 commit into
leanprover:masterfrom
Kha:push-urrykypuuvyv

Conversation

@Kha
Copy link
Copy Markdown
Member

@Kha Kha commented May 28, 2026

This PR makes the Lake tests that require a Git repository operate on a copy in an untracked work/ directory instead of running git init inside the checked-in source tree. This prevents the tracked test files from being reported as removed when a nested Git repository is created under version control.

@Kha Kha requested a review from tydeu May 28, 2026 16:02
@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 28, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

mathlib-lean-pr-testing Bot commented May 28, 2026

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 6de1d62f83565e01774358e8dce4a7aa3eebb482 --onto 2cd98639c40d2d2a026dd599093b70f55f55ffaf. You can force Mathlib CI using the force-mathlib-ci label. (2026-05-28 16:53:26)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 6de1d62f83565e01774358e8dce4a7aa3eebb482 --onto c47a0c7cf035381a2bcdd4cdf2442782eb4a5214. You can force Mathlib CI using the force-mathlib-ci label. (2026-05-29 10:23:02)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 6de1d62f83565e01774358e8dce4a7aa3eebb482 --onto 803553a556fd82fa1060efb0c43eda542130cb16. You can force reference manual CI using the force-manual-ci label. (2026-05-28 16:53:28)

This PR makes the Lake tests that require a Git repository operate on a copy in an untracked `work/` directory instead of running `git init` inside the checked-in source tree. This prevents the tracked test files from being reported as removed when a nested Git repository is created under version control.
@Kha Kha force-pushed the push-urrykypuuvyv branch from 93b74b6 to 87a5523 Compare May 29, 2026 09:30
Copy link
Copy Markdown
Member

@tydeu tydeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants