-
Notifications
You must be signed in to change notification settings - Fork 856
feat: add Environment.hasExposedBody helper #13868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kim-em
wants to merge
4
commits into
leanprover:master
Choose a base branch
from
kim-em:feat/Environment-hasExposedBody
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−7
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d3491f7
feat(Environment): add `Environment.hasExposedBody`
kim-em 02abfa6
fixup: rewrite hasExposedBody docstring, dedup getEnv, add test
kim-em d5bab2b
fix: move hasExposedBody to after Environment.find?
kim-em ffe7408
fix: avoid `guard` in hasExposedBody test
kim-em File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| module | ||
| import Lean.Elab.Command | ||
|
|
||
| /-! | ||
| # Tests for `Lean.Environment.hasExposedBody` | ||
|
|
||
| Confirms the function returns `true` only for `def`s whose body is exposed across | ||
| module boundaries, and `false` for theorems, opaques, axioms, inductives, | ||
| declarations not in the environment, and `def`s whose body is sealed by the | ||
| module system. | ||
| -/ | ||
|
|
||
| @[expose] def exposedDef : Nat := 0 | ||
| def sealedDef : Nat := 1 | ||
| theorem aTheorem : 0 = 0 := rfl | ||
| opaque anOpaque : Nat := 2 | ||
| axiom anAxiom : Nat | ||
| inductive AnInductive where | mk | ||
|
|
||
| run_cmd do | ||
| let env ← Lean.getEnv | ||
| unless env.hasExposedBody ``exposedDef do | ||
| throwError "`exposedDef` should have an exposed body" | ||
| for n in [``sealedDef, ``aTheorem, ``anOpaque, ``anAxiom, ``AnInductive, `nonexistent.name] do | ||
| if env.hasExposedBody n then | ||
| throwError "`{n}` should not have an exposed body" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too much information. "Checks if, in the public scope (
Environment.isExporting), the given name refers to a definition with a visible body, i.e.ConstantInfo.hasValue. Recall that outside the module system, this is any definition."I'm pretty sure the
!isModulecases are simply wrong