feat: add builtin linter sets and make linter.extra a builtin linter set#13852
Open
wkrozowski wants to merge 5 commits into
Open
feat: add builtin linter sets and make linter.extra a builtin linter set#13852wkrozowski wants to merge 5 commits into
linter.extra a builtin linter set#13852wkrozowski wants to merge 5 commits into
Conversation
Collaborator
|
Reference manual CI status:
|
|
Mathlib CI status (docs):
|
linter.extra a linter setlinter.extra a builtin linter set
a6f075d to
723b820
Compare
723b820 to
a6f075d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds builtin linter sets — linter sets registered from core Lean code during initialization, complementing the user-facing
register_linter_setcommand — and makeslinter.extraone of them. Enablinglinter.extra(e.g. viaset_option linter.extra trueorlake lint --extra) now activates the extra linters through the same set-membership mechanism as any other linter set.The extra linters (
dupNamespace,unnecessarySeqFocus,unreachableTactic,unusedDecidableInType) previously relied on dedicatedgetLinterValueExtraandlogLintIfExtrahelpers with a speciallinter.extrafallback; these are removed in favor of the standardgetLinterValue/logLintIf. Registering sets frombuiltin_initialize(before theregister_linter_setcommand elaborator is available) is supported by givinglinterSetsExtaLinterSetsStatethat folds a globalbuiltinLinterSetsRefof builtin sets into every environment, alongside imported and locally-declared entries.