experiment: always check types for instance metavariables at instance…#13846
Draft
TwoFX wants to merge 28 commits into
Draft
experiment: always check types for instance metavariables at instance…#13846TwoFX wants to merge 28 commits into
TwoFX wants to merge 28 commits into
Conversation
…tions This PR adds `implicit_reducible` and/or `expose` attributes to definitions that need to be unfolded during defeq checking without full transparency. Preparatory commit for removing the TODO workaround in ExprDefEq.lean. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…nprover#13823 (leanprover#13584) This PR fixes some warnings in stage2 due to redundant `@[expose]`.
This reverts commit cc007d9.
…for now" This reverts commit 987c895.
This reverts commit d74fd4a.
This PR adds two opt-in trace augmentations for debugging definitional equality. Setting `trace.Meta.isDefEq.printTransparency` prefixes each `Meta.isDefEq` `=?=` trace node with the current transparency level (e.g. `[default]`, `[instances]`, `[implicit]`). Enabling the new `Meta.isDefEq.transparency` trace class additionally logs the reason whenever `withInstanceConfig` or `withImplicitConfig` raises the transparency to check an instance-implicit or implicit-value argument. Implementation: adds a `ToString TransparencyMode` instance, registers the option and trace class, and instruments the two wrappers in `ExprDefEq.lean`. Both features are off by default and incur no cost when disabled. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
toolchain-available
leanprover-bot
added
the
breaks-manual
Collaborator
|
Reference manual CI status:
|
mathlib-lean-pr-testing
Bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
datokrat
force-pushed
the
defeq_todo_4_paul
branch
4 times, most recently
from
64eaca4 to
c467d9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.