fix: add a missing where to correct a vacuous class#431
Open
eric-wieser wants to merge 2 commits intomainfrom
Open
fix: add a missing where to correct a vacuous class#431eric-wieser wants to merge 2 commits intomainfrom
where to correct a vacuous class#431eric-wieser wants to merge 2 commits intomainfrom
Conversation
eric-wieser
force-pushed
the
eric-wieser/where
branch
2 times, most recently
from
e15e967 to
baa506c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this class said "Given an LTS with finite image and finite outgoing labels, we say it is finitely branching if <empty condition>`. This was nonsense, and also made it impossible to state that something was not finitely branching.
This adds the missing
wherekeyword such that it instead as "Given an LTS, we say it is finitely branching if it has finite image and finite outgoing labels".