feat(LaplaceRungeLenzVector): prove angularMomentum_commutation_lrl#991
Open
pitmonticone wants to merge 4 commits intoleanprover-community:masterfrom
Open
feat(LaplaceRungeLenzVector): prove angularMomentum_commutation_lrl#991pitmonticone wants to merge 4 commits intoleanprover-community:masterfrom
angularMomentum_commutation_lrl#991pitmonticone wants to merge 4 commits intoleanprover-community:masterfrom
Conversation
Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
PhysLean/QuantumMechanics/DDimensions/Hydrogen/LaplaceRungeLenzVector.lean
Outdated
Show resolved
Hide resolved
PhysLean/QuantumMechanics/DDimensions/Hydrogen/LaplaceRungeLenzVector.lean
Outdated
Show resolved
Hide resolved
PhysLean/QuantumMechanics/DDimensions/Hydrogen/LaplaceRungeLenzVector.lean
Outdated
Show resolved
Hide resolved
- Combine consecutive simp only calls - Extract inline show to named have neg_ite_zero - Replace all_goals with <;> chaining from split_ifs Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
Member
Author
|
Submitted your review comments to @Aristotle-Harmonic and it should have resolved them all. |
…ks rw) Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
Member
|
The build here emits a bunch of warnings of the form It is also possible to combine some of the |
jstoobysmith
added
the
awaiting-author
…d have Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
Member
Author
|
The latest push removes all unused simp arguments — the build should now be warning-free. Regarding combining the simps: we tried several combinations but the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds proofs autoformalised by @Aristotle-Harmonic.
Co-authored-by: Aristotle (Harmonic) aristotle-harmonic@harmonic.fun