Skip to content

refactor: Reorganise the QuantumInfo directory #1124

Open
jstoobysmith wants to merge 5 commits into
leanprover-community:masterfrom
jstoobysmith:moveQuantumInfoFiles
Open

refactor: Reorganise the QuantumInfo directory #1124
jstoobysmith wants to merge 5 commits into
leanprover-community:masterfrom
jstoobysmith:moveQuantumInfoFiles

Conversation

@jstoobysmith
Copy link
Copy Markdown
Member

No changes to content, just a reorganisation. New directory structure is the following:

QuantumInfo
 ┣ Capacity
 ┃ ┣ Capacity.lean
 ┃ ┗ Capacity_doc.lean
 ┣ Channels
 ┃ ┣ Bundled.lean
 ┃ ┣ CPTP.lean
 ┃ ┣ DegradableOrder.lean
 ┃ ┣ Dual.lean
 ┃ ┣ MatrixMap.lean
 ┃ ┣ Pinching.lean
 ┃ ┗ Unbundled.lean
 ┣ ClassicalInfo
 ┃ ┣ ForMathlib
 ┃ ┃ ┗ Analysis
 ┃ ┃ ┃ ┗ SpecialFunctions
 ┃ ┃ ┃ ┃ ┗ Log
 ┃ ┃ ┃ ┃ ┃ ┗ NegMulLog.lean
 ┃ ┣ Capacity.lean
 ┃ ┣ Channel.lean
 ┃ ┣ Distribution.lean
 ┃ ┣ Entropy.lean
 ┃ ┗ Prob.lean
 ┣ Entropy
 ┃ ┣ Axiomatized
 ┃ ┃ ┣ Defs.lean
 ┃ ┃ ┗ Renyi.lean
 ┃ ┣ DPI.lean
 ┃ ┣ Relative.lean
 ┃ ┣ SSA.lean
 ┃ ┗ VonNeumann.lean
 ┣ ForMathlib
 ┃ ┣  ...
 ┣ Measurements
 ┃ ┗ POVM.lean
 ┣ Operators
 ┃ ┗ Unitary.lean
 ┣ ResourceTheory
 ┃ ┣ FreeState.lean
 ┃ ┣ HypothesisTesting.lean
 ┃ ┣ ResourceTheory.lean
 ┃ ┗ SteinsLemma.lean
 ┣ States
 ┃ ┣ Mixed
 ┃ ┃ ┣ Fidelity.lean
 ┃ ┃ ┣ MState.lean
 ┃ ┃ ┗ TraceDistance.lean
 ┃ ┣ Pure
 ┃ ┃ ┣ BargmannInvariant.lean
 ┃ ┃ ┣ Braket.lean
 ┃ ┃ ┗ Qubit.lean
 ┃ ┣ Ensemble.lean
 ┃ ┗ Entanglement.lean
 ┗ Regularized.lean

@jstoobysmith jstoobysmith added t-quantum-info Quantum information RFC Request for comment labels May 26, 2026
Copy link
Copy Markdown
Contributor

@wock9000 wock9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally — builds clean. Verified that BargmannInvariant.lean works correctly at the new States/Pure/ path with the updated import.

The States/Pure/ vs States/Mixed/ split is clean. For our follow-up PRs (Pancharatnam solid angle, N-level generalization), the placement under States/Pure/ makes sense since geometric phase is a property of pure state evolution.

One note for our own tracking: our open PR #1126 targets QuantumInfo/Finite/GeometricPhase/ which will need rebasing once this merges. Happy to handle that.

wock9000

This comment was marked as duplicate.

@morrison-daniel
Copy link
Copy Markdown
Collaborator

I think the organization makes sense, but I'd like to wait for approval from someone more familiar with QuantumInfo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFC Request for comment t-quantum-info Quantum information

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants