Skip to content

feat(Combinatorics/Enumerative): GeneratingFunction/ part 2/13#39660

Open
rwst wants to merge 2 commits into
leanprover-community:masterfrom
rwst:comb02
Open

feat(Combinatorics/Enumerative): GeneratingFunction/ part 2/13#39660
rwst wants to merge 2 commits into
leanprover-community:masterfrom
rwst:comb02

Conversation

@rwst
Copy link
Copy Markdown
Collaborator

@rwst rwst commented May 21, 2026

Please see my declaration of collaboration there.

rwst and others added 2 commits May 21, 2026 13:00
This file is part of my plan for a "Combinatorial Class" implementing
the infrastructure to associate combinatorial object enumeration with
their generating function, as described in Flajolet-Sedgewick. Opus 4.7
made the choice of finite fibers and wrote the Lean code. I looked at
every line and learned. Zulip commenters pointed at missing
functionality. I made design decisions, in particular removal of
structures in favor of functional lemmas and definitions, so after all,
the "Combinatorial Class" stays undefined. I also removed lots of
superfluous docstring text from all files. As to the commits, Opus has
no rights to use git on my machine.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file is part of my plan for a "Combinatorial Class" implementing
the infrastructure to associate combinatorial object enumeration with
their generating function, as described in Flajolet-Sedgewick. Opus 4.7
made the choice of finite fibers and wrote the Lean code. I looked at
every line and learned. Zulip commenters pointed at missing
functionality. I made design decisions, in particular removal of
structures in favor of functional lemmas and definitions, so after all,
the "Combinatorial Class" stays undefined. I also removed lots of
superfluous docstring text from all files. As to the commits, Opus has
no rights to use git on my machine.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the t-combinatorics Combinatorics label May 21, 2026
@github-actions
Copy link
Copy Markdown

PR summary 5dc218ec8f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Combinatorics.Enumerative.GeneratingFunction.Defs (new file) 1152
Mathlib.Combinatorics.Enumerative.GeneratingFunction.Sum (new file) 1154

Declarations diff

+ FiniteFibers
+ card_sumElim_fiber
+ coeff_genFun
+ deg
+ deg_eq_zero_iff
+ genFun
+ genFun_congr
+ genFun_sum
+ instFiniteFibersOfFinite
+ instFiniteFibersSumElim
+ sumFiberEquiv

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@rwst rwst added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 21, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

This PR/issue depends on:

@rwst rwst changed the title feat(Combinatorics/Enumerative): GeneratingFunction/ part 2 feat(Combinatorics/Enumerative): GeneratingFunction/ part 2/13 May 21, 2026
@SnirBroshi SnirBroshi added the LLM-generated PRs with substantial input from LLMs - review accordingly label May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) LLM-generated PRs with substantial input from LLMs - review accordingly t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants