Skip to content

feat(AlgebraicGeometry/Birational): dominant rational maps#39317

Open
justus-springer wants to merge 8 commits into
leanprover-community:masterfrom
justus-springer:justus/rationalMap_dominant
Open

feat(AlgebraicGeometry/Birational): dominant rational maps#39317
justus-springer wants to merge 8 commits into
leanprover-community:masterfrom
justus-springer:justus/rationalMap_dominant

Conversation

@justus-springer
Copy link
Copy Markdown
Collaborator

@justus-springer justus-springer commented May 13, 2026

Add a predicate RationalMap.IsDominant and add basic API. This is in preparation for defining composition of rational maps (see #39445). See also stacks#01RR.


Open in Gitpod

@github-actions github-actions Bot added the t-algebraic-geometry Algebraic geometry label May 13, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

PR summary 4a89d29c3f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.AlgebraicGeometry.Birational.Dominant (new file) 2456

Declarations diff

+ PartialMap.isDominant_toRationalMap
+ PartialMap.isDominant_toRationalMap_iff
+ PartialMap.representative_toRationalMap_equiv
+ RationalMap.IsDominant
+ RationalMap.isDominant_representative
+ RationalMap.representative
+ RationalMap.toRationalMap_representative
+ isDominant_hom_iff_isDominant_restrict_hom
+ isDominant_hom_iff_of_equiv
+ isDominant_hom_of_isDominant_restrict_hom
+ isDominant_restrict_hom

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@github-actions github-actions Bot added the file-removed A Lean module was (re)moved without a `deprecated_module` annotation label May 13, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels May 13, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

mathlib-dependent-issues Bot commented May 13, 2026

@github-actions github-actions Bot removed the file-removed A Lean module was (re)moved without a `deprecated_module` annotation label May 13, 2026
Comment thread Mathlib/AlgebraicGeometry/Birational/Dominant.lean Outdated
Comment thread Mathlib/AlgebraicGeometry/Birational/Dominant.lean Outdated
Comment thread Mathlib/AlgebraicGeometry/Birational/Dominant.lean Outdated
@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes. label May 21, 2026
@chrisflav chrisflav self-assigned this May 21, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 21, 2026
@justus-springer justus-springer removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants