feat(Algebra/Lie/Sl2): add lemma exists_primitiveVector#37661
feat(Algebra/Lie/Sl2): add lemma exists_primitiveVector#37661pion2024 wants to merge 9 commits intoleanprover-community:masterfrom
Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary b446ba6ef7Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Lie.Sl2 | 1469 | 1832 | +363 (+24.71%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Algebra.Lie.Sl2 |
363 |
Declarations diff
+ IsTriangularizable.exists_hasEigenvalue
+ exists_hasPrimitiveVectorWith
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
ocfnash
left a comment
There was a problem hiding this comment.
Thanks, I'll return once you've had a chance to consider my initial suggestions.
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
…on2024/mathlib4 into split2-exists_primitiveVector
Thanks, I've applied your suggestions. |
|
@pion2024 Sorry I've been slow to return: I'll prioritise this next week. |
No worries, please take your time as I am actually a bit tied up myself. I'll still do my best to address your feedback as soon as I can. |
split 2 for the PR #37010