Skip to content

feat(Algebra/Lie/Sl2): add lemma exists_primitiveVector#37661

Open
pion2024 wants to merge 9 commits intoleanprover-community:masterfrom
pion2024:split2-exists_primitiveVector
Open

feat(Algebra/Lie/Sl2): add lemma exists_primitiveVector#37661
pion2024 wants to merge 9 commits intoleanprover-community:masterfrom
pion2024:split2-exists_primitiveVector

Conversation

@pion2024
Copy link
Copy Markdown
Contributor

@pion2024 pion2024 commented Apr 5, 2026

split 2 for the PR #37010

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Apr 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

PR summary b446ba6ef7

Import changes exceeding 2%

% File
+24.71% Mathlib.Algebra.Lie.Sl2

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Lie.Sl2 1469 1832 +363 (+24.71%)
Import changes for all files
Files Import difference
Mathlib.Algebra.Lie.Sl2 363

Declarations diff

+ IsTriangularizable.exists_hasEigenvalue
+ exists_hasPrimitiveVectorWith

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 5, 2026
@ocfnash ocfnash self-assigned this Apr 9, 2026
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll return once you've had a chance to consider my initial suggestions.

Comment thread Mathlib/Algebra/Lie/Sl2.lean Outdated
Comment thread Mathlib/Algebra/Lie/Sl2.lean Outdated
Comment thread Mathlib/Algebra/Lie/Sl2.lean Outdated
@ocfnash ocfnash added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 9, 2026
pion2024 and others added 6 commits April 10, 2026 19:15
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
@pion2024
Copy link
Copy Markdown
Contributor Author

Thanks, I'll return once you've had a chance to consider my initial suggestions.

Thanks, I've applied your suggestions.

@ocfnash ocfnash removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 17, 2026
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Apr 17, 2026

@pion2024 Sorry I've been slow to return: I'll prioritise this next week.

@pion2024
Copy link
Copy Markdown
Contributor Author

@pion2024 Sorry I've been slow to return: I'll prioritise this next week.

No worries, please take your time as I am actually a bit tied up myself. I'll still do my best to address your feedback as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants