Skip to content

[Merged by Bors] - chore(MeasureTheory/Measure/MeasureSpace): reduce privateInPublic#37657

Closed
Komyyy wants to merge 5 commits intoleanprover-community:masterfrom
Komyyy:instCompleteSemilatticeInf
Closed

[Merged by Bors] - chore(MeasureTheory/Measure/MeasureSpace): reduce privateInPublic#37657
Komyyy wants to merge 5 commits intoleanprover-community:masterfrom
Komyyy:instCompleteSemilatticeInf

Conversation

@Komyyy
Copy link
Copy Markdown
Contributor

@Komyyy Komyyy commented Apr 5, 2026


Open in Gitpod

@Komyyy Komyyy added t-measure-probability Measure theory / Probability theory tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Apr 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

PR summary 63868fe5ba

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.68, 0.01)
Current number Change Type
806 -3 backward.privateInPublic
415 -1 backward.privateInPublic.warn

Current commit 78b7c00d4d
Reference commit 63868fe5ba

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@JovanGerb
Copy link
Copy Markdown
Contributor

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

🚀 Pull request has been placed on the maintainer queue by JovanGerb.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 6, 2026
@sgouezel
Copy link
Copy Markdown
Contributor

sgouezel commented Apr 6, 2026

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 6, 2026
@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 6, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 6, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(MeasureTheory/Measure/MeasureSpace): reduce privateInPublic [Merged by Bors] - chore(MeasureTheory/Measure/MeasureSpace): reduce privateInPublic Apr 6, 2026
@mathlib-bors mathlib-bors bot closed this Apr 6, 2026
riccardobrasca pushed a commit to riccardobrasca/mathlib4 that referenced this pull request Apr 6, 2026
YellPika pushed a commit to YellPika/mathlib4 that referenced this pull request Apr 6, 2026
@Komyyy Komyyy deleted the instCompleteSemilatticeInf branch April 7, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants