[Merged by Bors] - feat(Analysis/Calculus/FDeriv): add fderiv_apply simp lemmas#37637
[Merged by Bors] - feat(Analysis/Calculus/FDeriv): add fderiv_apply simp lemmas#37637IlPreteRosso wants to merge 6 commits intoleanprover-community:masterfrom
Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary eb4f246868Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
One question about the direction. In my downstream project the pattern that shows up frequently is The @[simp]
lemma fderiv_apply {Φ : E → ∀ i, F' i} (hΦ : DifferentiableAt 𝕜 Φ x) (v : E) (i : ι) :
fderiv 𝕜 Φ x v i = fderiv 𝕜 (fun x => Φ x i) x v := by
rw [fderiv_pi']; ... Ok I misunderstood the |
| (hasFDerivAt_pi.2 fun i => (h i).hasFDerivAt).fderiv | ||
|
|
||
| @[simp] | ||
| theorem fderivWithin_pi' (hΦ : DifferentiableWithinAt 𝕜 Φ s x) |
There was a problem hiding this comment.
| theorem fderivWithin_pi' (hΦ : DifferentiableWithinAt 𝕜 Φ s x) | |
| theorem fderivWithin_apply (hΦ : DifferentiableWithinAt 𝕜 Φ s x) |
is now the right name I think; my comment earlier was that your name suggested the current direction but the type was the opposite.
There was a problem hiding this comment.
Ah apologies, I missed the message above. Perhaps get a second opinion
There was a problem hiding this comment.
Ah apologies, I missed the message above. Perhaps get a second opinion
No worries. I was not folloing the api's _apply implication ealier on. Let me know your opinion.
…hlib4 into fderiv-pi-apply
j-loreaux
left a comment
There was a problem hiding this comment.
I think apply is the right name here. Thanks!
bors merge
Add `@[simp]` lemmas `fderiv_apply` and `fderivWithin_apply` that extract a component from the fderiv of a Pi-type function: `(proj i).comp (fderiv 𝕜 Φ x) = fderiv 𝕜 (fun x => Φ x i) x`. This completes the extraction direction of the Pi fderiv API alongside the existing construction direction (`fderiv_pi`). Co-authored-by: Fengyang Wang <will1541286313@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
…ver-community#37637) Add `@[simp]` lemmas `fderiv_apply` and `fderivWithin_apply` that extract a component from the fderiv of a Pi-type function: `(proj i).comp (fderiv 𝕜 Φ x) = fderiv 𝕜 (fun x => Φ x i) x`. This completes the extraction direction of the Pi fderiv API alongside the existing construction direction (`fderiv_pi`). Co-authored-by: Fengyang Wang <will1541286313@gmail.com>
Add
@[simp]lemmasfderiv_applyandfderivWithin_applythat extract a component from the fderiv of a Pi-type function:(proj i).comp (fderiv 𝕜 Φ x) = fderiv 𝕜 (fun x => Φ x i) x. This completes the extraction direction of the Pi fderiv API alongside the existing construction direction (fderiv_pi).