[Merged by Bors] - chore(Analysis/Analytic): tag ofScalars_norm_eq_mul with simp#37635
[Merged by Bors] - chore(Analysis/Analytic): tag ofScalars_norm_eq_mul with simp#37635vasnesterov wants to merge 1 commit intoleanprover-community:masterfrom
ofScalars_norm_eq_mul with simp#37635Conversation
PR summary 290b6cf8beImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
!bench |
|
Benchmark results for a202151 against 290b6cf are in. There are no significant changes. @vasnesterov
Small changes (1🟥)
|
| [NormedAlgebra 𝕜 E] (c : ℕ → 𝕜) (n : ℕ) | ||
|
|
||
| @[simp] | ||
| theorem ofScalars_norm_eq_mul : |
There was a problem hiding this comment.
Without commenting on the simp tagging, this name of this and the other lemma below are wrong, they should be norm_ofScalars_....
There was a problem hiding this comment.
Should I rename it in this PR?
There was a problem hiding this comment.
Probably a new PR so that this can stay on topic (i.e., adding @[simp])
|
It's not clear to be that |
|
@ocfnash I think it's reasonable. Note that when the algebra satisfies @vasnesterov if Oliver doesn't complain in say, 24 hours, you can merge this. bors d+ |
|
✌️ vasnesterov can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Thanks, I'm convinced! bors merge |
…7635) Tag `ofScalars_norm_eq_mul` with `simp` and remove `@[simp]` from `ofScalars_norm` as it now can be proven using `ofScalars_norm_eq_mul`.
|
Pull request successfully merged into master. Build succeeded:
|
ofScalars_norm_eq_mul with simpofScalars_norm_eq_mul with simp
Tag
ofScalars_norm_eq_mulwithsimpand remove@[simp]fromofScalars_normas it now can be proven usingofScalars_norm_eq_mul.