Skip to content

[Merged by Bors] - chore(Analysis/Analytic): tag ofScalars_norm_eq_mul with simp#37635

Closed
vasnesterov wants to merge 1 commit intoleanprover-community:masterfrom
vasnesterov:ofScalars_norm_eq_mul_simp
Closed

[Merged by Bors] - chore(Analysis/Analytic): tag ofScalars_norm_eq_mul with simp#37635
vasnesterov wants to merge 1 commit intoleanprover-community:masterfrom
vasnesterov:ofScalars_norm_eq_mul_simp

Conversation

@vasnesterov
Copy link
Copy Markdown
Collaborator

Tag ofScalars_norm_eq_mul with simp and remove @[simp] from ofScalars_norm as it now can be proven using ofScalars_norm_eq_mul.


Open in Gitpod

@vasnesterov vasnesterov added the t-analysis Analysis (normed *, calculus) label Apr 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

PR summary 290b6cf8be

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@vasnesterov vasnesterov added the easy < 20s of review time. See the lifecycle page for guidelines. label Apr 4, 2026
@vasnesterov
Copy link
Copy Markdown
Collaborator Author

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 5, 2026

Benchmark results for a202151 against 290b6cf are in. There are no significant changes. @vasnesterov

  • build//instructions: -4.6G (-0.00%)

Small changes (1🟥)

  • 🟥 build/module/Mathlib.Tactic.Cases//instructions: +410.5M (+6.06%)

[NormedAlgebra 𝕜 E] (c : ℕ → 𝕜) (n : ℕ)

@[simp]
theorem ofScalars_norm_eq_mul :
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without commenting on the simp tagging, this name of this and the other lemma below are wrong, they should be norm_ofScalars_....

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I rename it in this PR?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a new PR so that this can stay on topic (i.e., adding @[simp])

@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Apr 7, 2026

It's not clear to be that ofScalars_norm_eq_mul should be simp. Could you give a bit of motivation?

@j-loreaux
Copy link
Copy Markdown
Contributor

@ocfnash I think it's reasonable. Note that when the algebra satisfies NormOneClass, then ContinuousMultilinearMap.norm_mkPiAlgebraFin means the right-hand side will simplify to ‖c n‖, which seems like a thing we want.

@vasnesterov if Oliver doesn't complain in say, 24 hours, you can merge this.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 7, 2026

✌️ vasnesterov can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Apr 7, 2026
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Apr 8, 2026

Thanks, I'm convinced!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 8, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 8, 2026
…7635)

Tag `ofScalars_norm_eq_mul` with `simp` and remove `@[simp]` from `ofScalars_norm` as it now can be proven using `ofScalars_norm_eq_mul`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 8, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Analysis/Analytic): tag ofScalars_norm_eq_mul with simp [Merged by Bors] - chore(Analysis/Analytic): tag ofScalars_norm_eq_mul with simp Apr 8, 2026
@mathlib-bors mathlib-bors bot closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants