Skip to content

[Merged by Bors] - chore(CI): check all lean scripts build successfully#37634

Closed
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:build-createmoduledepr
Closed

[Merged by Bors] - chore(CI): check all lean scripts build successfully#37634
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:build-createmoduledepr

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Apr 4, 2026

This would have caught the errors fixed by #37391 much sooner.
The list of scripts included in this PR is based on manual inspection
of scripts/, and removing any which get run using any PR's CI run anyway.


Open in Gitpod

@grunweg grunweg changed the title Build createmoduledepr chore(CI): check all lean scripts build successfully Apr 4, 2026
@grunweg grunweg added the CI Modifies the continuous integration setup or other automation label Apr 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

PR summary fea9737125

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

⚠️ Workflow documentation reminder

This PR modifies files under .github/workflows/.
Please update docs/workflows.md if the workflow inventory, triggers, or behavior changed.

Modified workflow files:

  • .github/workflows/build_template.yml

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@grunweg grunweg force-pushed the build-createmoduledepr branch from 29fbb2e to b20d38d Compare April 4, 2026 15:56
@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 4, 2026
@grunweg grunweg force-pushed the build-createmoduledepr branch from b20d38d to 46e6838 Compare April 7, 2026 07:55
@grunweg grunweg requested a review from bryangingechen April 7, 2026 07:56
This would have caught the errors fixed by leanprover-community#37391 much sooner.
The list of scripts included in this PR is based on manual inspection
of scripts/, and removing any which get run using any PR's CI run anyway.
@grunweg grunweg force-pushed the build-createmoduledepr branch from 46e6838 to 9234b8f Compare April 7, 2026 07:56
@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 7, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

This PR/issue depends on:

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Apr 7, 2026

bors merge

@kim-em kim-em closed this Apr 7, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 7, 2026

Already running a review

@kim-em kim-em reopened this Apr 7, 2026
@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 7, 2026
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Apr 7, 2026

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Apr 7, 2026
This would have caught the errors fixed by #37391 much sooner.
The list of scripts included in this PR is based on manual inspection
of scripts/, and removing any which get run using any PR's CI run anyway.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 7, 2026

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Apr 7, 2026
This would have caught the errors fixed by #37391 much sooner.
The list of scripts included in this PR is based on manual inspection
of scripts/, and removing any which get run using any PR's CI run anyway.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 7, 2026

Build failed:

Fix if necessary, and then someone with permission can run bors r+ or bors retry.

Copy link
Copy Markdown
Contributor

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 7, 2026

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Apr 7, 2026
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Apr 10, 2026

Let's try again:
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Apr 10, 2026
This would have caught the errors fixed by #37391 much sooner.
The list of scripts included in this PR is based on manual inspection
of scripts/, and removing any which get run using any PR's CI run anyway.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 10, 2026

Build failed:

Fix if necessary, and then someone with permission can run bors r+ or bors retry.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Apr 10, 2026

bors retry

mathlib-bors bot pushed a commit that referenced this pull request Apr 10, 2026
This would have caught the errors fixed by #37391 much sooner.
The list of scripts included in this PR is based on manual inspection
of scripts/, and removing any which get run using any PR's CI run anyway.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 10, 2026

Build failed:

Fix if necessary, and then someone with permission can run bors r+ or bors retry.

@bryangingechen
Copy link
Copy Markdown
Contributor

There's an actual error there, right? https://github.com/leanprover-community/mathlib4/actions/runs/24239427332/job/70771007683#step:11:20

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Apr 10, 2026

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Apr 10, 2026
This would have caught the errors fixed by #37391 much sooner.
The list of scripts included in this PR is based on manual inspection
of scripts/, and removing any which get run using any PR's CI run anyway.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 10, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(CI): check all lean scripts build successfully [Merged by Bors] - chore(CI): check all lean scripts build successfully Apr 10, 2026
@mathlib-bors mathlib-bors bot closed this Apr 10, 2026
@grunweg grunweg deleted the build-createmoduledepr branch April 10, 2026 12:37
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Apr 10, 2026
…unity#37634)

This would have caught the errors fixed by leanprover-community#37391 much sooner.
The list of scripts included in this PR is based on manual inspection
of scripts/, and removing any which get run using any PR's CI run anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants