feat(Order/RelIso): add theorems about RelHom.comp and RelEmbedding.trans#37623
Open
IvanRenison wants to merge 1 commit intoleanprover-community:masterfrom
Open
feat(Order/RelIso): add theorems about RelHom.comp and RelEmbedding.trans#37623IvanRenison wants to merge 1 commit intoleanprover-community:masterfrom
RelHom.comp and RelEmbedding.trans#37623IvanRenison wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
Co-authored-by: SnirBroshi <26556598+SnirBroshi@users.noreply.github.com>
PR summary 6a7332dd00Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
SnirBroshi
approved these changes
Apr 3, 2026
Comment on lines
+150
to
+152
| theorem comp_id (f : r →r s) : f.comp (RelHom.id r) = f := rfl | ||
|
|
||
| theorem id_comp (f : r →r s) : (RelHom.id s).comp f = f := rfl |
Collaborator
There was a problem hiding this comment.
simp?
Suggested change
| theorem comp_id (f : r →r s) : f.comp (RelHom.id r) = f := rfl | |
| theorem id_comp (f : r →r s) : (RelHom.id s).comp f = f := rfl | |
| @[simp] | |
| theorem comp_id (f : r →r s) : f.comp (RelHom.id r) = f := rfl | |
| @[simp] | |
| theorem id_comp (f : r →r s) : (RelHom.id s).comp f = f := rfl |
Comment on lines
+290
to
+292
| theorem trans_refl (f : r ↪r s) : f.trans (.refl s) = f := rfl | ||
|
|
||
| theorem refl_trans (f : r ↪r s) : .trans (.refl r) f = f := rfl |
Collaborator
There was a problem hiding this comment.
simp?
Suggested change
| theorem trans_refl (f : r ↪r s) : f.trans (.refl s) = f := rfl | |
| theorem refl_trans (f : r ↪r s) : .trans (.refl r) f = f := rfl | |
| @[simp] | |
| theorem trans_refl (f : r ↪r s) : f.trans (.refl s) = f := rfl | |
| @[simp] | |
| theorem refl_trans (f : r ↪r s) : .trans (.refl r) f = f := rfl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: SnirBroshi 26556598+SnirBroshi@users.noreply.github.com
Missing of this theorems noticed by @SnirBroshi in #37598