Skip to content

feat: if E is finite dimensional, E →L[𝕜] F has the product topology#36775

Open
ADedecker wants to merge 41 commits intoleanprover-community:masterfrom
ADedecker:AD_embedding_coeFn_of_finiteDimensional
Open

feat: if E is finite dimensional, E →L[𝕜] F has the product topology#36775
ADedecker wants to merge 41 commits intoleanprover-community:masterfrom
ADedecker:AD_embedding_coeFn_of_finiteDimensional

Conversation

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Mar 17, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 17, 2026

PR summary 8f1377de1f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Topology.Algebra.Module.FiniteDimensionStrongTopology (new file) 1961

Declarations diff

+ ContinuousLinearMap.flipOfFiniteDimensional
+ ContinuousLinearMap.flipOfFiniteDimensional_apply
+ ContinuousLinearMap.flipOfFiniteDimensional_symm_apply
+ ContinuousLinearMap.isEmbedding_coeFn_of_finiteDimensional
+ ContinuousLinearMap.isUniformEmbedding_coeFn_of_finiteDimensional
+ Module.Basis.constrCLE
+ Module.Basis.continuous_constrL
+ UniformConvergenceCLM.piEquivL
+ arrowCongrEquivₛₗ
+ constrCLE
+ continuous_constrL
+ flipOfBasis
+ flipOfBasis_apply
+ flipOfBasis_symm_apply
+ flipOfFiniteDimensional
+ flipOfFiniteDimensional_apply
+ flipOfFiniteDimensional_symm_apply
+ isEmbedding_coeFn_of_finiteDimensional
+ isUniformEmbedding_coeFn_of_finiteDimensional
+ piEquivL
+ uniformConvergenceCLMCongr
+ uniformConvergenceCLMCongrSL

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 17, 2026
fun_prop

variable (R) in
protected noncomputable def Module.Basis.constrLCLE [Finite ι] (b : Basis ι 𝕜 E) :
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
protected noncomputable def Module.Basis.constrLCLE [Finite ι] (b : Basis ι 𝕜 E) :
protected noncomputable def Module.Basis.constrCLE [Finite ι] (b : Basis ι 𝕜 E) :

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nevermind. I think a docstring would have helped my confusion.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that constrCLE reads better. It is a bit less precise, but maybe that's okay? As in, because there's topology around, it's clear from context that we are talking about continuous linear maps?

@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 18, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 18, 2026
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 18, 2026
@ADedecker ADedecker marked this pull request as ready for review March 19, 2026 17:20
@mathlib-dependent-issues mathlib-dependent-issues bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Mar 19, 2026
@ADedecker ADedecker added the WIP Work in progress label Mar 30, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 1, 2026
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 3, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-topology Topological spaces, uniform spaces, metric spaces, filters WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants