Skip to content

feat(Geometry/Manifold): orientable manifolds#35376

Open
michaellee94 wants to merge 11 commits intoleanprover-community:masterfrom
michaellee94:michaellee94/orientation-v2
Open

feat(Geometry/Manifold): orientable manifolds#35376
michaellee94 wants to merge 11 commits intoleanprover-community:masterfrom
michaellee94:michaellee94/orientation-v2

Conversation

@michaellee94
Copy link
Collaborator

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Feb 15, 2026
@github-actions
Copy link

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link

github-actions bot commented Feb 15, 2026

PR summary 7314c8ed3a

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Geometry.Manifold.Instances.Real 2271 2284 +13 (+0.57%)
Mathlib.Geometry.Manifold.IsManifold.InteriorBoundary 2201 2208 +7 (+0.32%)
Import changes for all files
Files Import difference
Mathlib.Geometry.Manifold.WhitneyEmbedding 2
Mathlib.Geometry.Manifold.Riemannian.Basic Mathlib.Geometry.Manifold.Riemannian.PathELength 3
Mathlib.Geometry.Manifold.Bordism Mathlib.Geometry.Manifold.IsManifold.InteriorBoundary 7
3 files Mathlib.Geometry.Manifold.Instances.Sphere Mathlib.Geometry.Manifold.PoincareConjecture Mathlib.Topology.Compactification.OnePoint.Sphere
8
Mathlib.Geometry.Manifold.Instances.Icc 10
Mathlib.Geometry.Manifold.Instances.Real 13
Mathlib.Geometry.Manifold.Orientation (new file) 2282

Declarations diff

+ IccInteriorOpens
+ ManifoldOrientation
+ ManifoldOrientation.compatible_and_locallyConstant
+ ManifoldOrientation.ext_sign
+ ManifoldOrientation.tangentOrientation
+ ManifoldOrientation.tangentOrientation_eq_positive_or_neg
+ Orientable
+ OrientationPreservingOn
+ OrientedManifold
+ _root_.DifferentiableAt.mem_interior_convex_of_surjective_fderiv
+ baseOrientation
+ coe_IccInteriorOpens_eq_interior
+ contDiffOn_extCoordChange
+ contDiffOn_extCoordChange_symm
+ extCoordChange
+ extCoordChange_symm
+ instHasGroupoidIccInteriorOrientation
+ instOrientableIcc
+ instOrientedManifoldIcc
+ instance (M : Type*) [TopologicalSpace M] [ChartedSpace H M] [IsManifold I 1 M]
+ instance : ClosedUnderRestriction (orientationPreservingGroupoid I)
+ instance {n : WithTop ℕ∞} [IsManifold I n M] (hn : n ≠ 0) :
+ interiorOpens
+ isBoundaryPoint_iff_of_mem_atlas
+ isClosed_boundary
+ isInteriorPoint_iff_of_mem_atlas
+ isInvertible_fderivWithin_extCoordChange
+ isOpen_interior
+ jacobianDetWithin
+ mem_frontier_iff_notMem_interior
+ mem_interior_iff_notMem_frontier
+ mem_orientationPreservingGroupoid_iff
+ modelSet
+ modelSet_inter
+ modelSet_uniqueDiffOn
+ ofSet_mem_orientationPreservingGroupoid
+ orientationFromSign
+ orientationPreservingGroupoid
+ orientationPreservingGroupoid_le_contDiffGroupoid
+ orientationPreservingOn_ofSet
+ orientationPreservingPregroupoid
+ orientedTangentOrientation
+ point_has_two_manifoldOrientations
+ uniqueDiffOn_extCoordChange_source
+ uniqueDiffOn_extCoordChange_target

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@michaellee94 michaellee94 changed the title feat: orientable manifolds feat(Geometry/Manifold): orientable manifolds Feb 15, 2026
@michaellee94 michaellee94 added WIP Work in progress t-differential-geometry Manifolds etc labels Feb 15, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 15, 2026
@mathlib-dependent-issues
Copy link

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-differential-geometry Manifolds etc WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant