Skip to content

[Merged by Bors] - feat(LinearAlgebra/Simplex): lemma for subset/disjoint relation between interior of simplex and its faces#35365

Closed
wwylele wants to merge 16 commits intoleanprover-community:masterfrom
wwylele:simplex-face-interior
Closed

[Merged by Bors] - feat(LinearAlgebra/Simplex): lemma for subset/disjoint relation between interior of simplex and its faces#35365
wwylele wants to merge 16 commits intoleanprover-community:masterfrom
wwylele:simplex-face-interior

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented Feb 15, 2026

Intermediate lemma towards #34826. This will be used to show the measure on interior and closedInterior are equal, as the difference is a zero-measure set.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 15, 2026

PR summary 9b51fe6ec0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ closedInterior_diff_interior
+ closedInterior_eq_interior_union
+ closedInterior_faceOpposite_ssubset_closedInterior
+ closedInterior_faceOpposite_subset_closedInterior
+ closedInterior_face_ssubset_closedInterior
+ closedInterior_face_subset_closedInterior
+ disjoint_interior_closedInterior_face
+ disjoint_interior_closedInterior_faceOpposite
+ point_mem_closedInterior_faceOpposite_iff
+ point_mem_closedInterior_face_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 15, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an intermediate lemma in Affine.Simplex relating closedInterior to interior plus the union of the closedInteriors of codimension-1 faces (faceOpposite), intended for later measure-theoretic arguments in #34826.

Changes:

  • Prove (s.face h).closedInterior ⊆ s.closedInterior.
  • Prove s.closedInterior = s.interior ∪ ⋃ i, (s.faceOpposite i).closedInterior under ordered-ring assumptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Mathlib/LinearAlgebra/AffineSpace/Simplex/Basic.lean Outdated
Comment thread Mathlib/LinearAlgebra/AffineSpace/Simplex/Basic.lean Outdated
Comment thread Mathlib/LinearAlgebra/AffineSpace/Simplex/Basic.lean Outdated
@wwylele wwylele force-pushed the simplex-face-interior branch from fb3b3d7 to 8d1abcd Compare February 15, 2026 16:28
@wwylele wwylele changed the title feat(LinearAlgebra/AffineSpace): closedInterior = interior + face.closedInterior feat(LinearAlgebra/Simplex): closedInterior = interior + face.closedInterior Feb 15, 2026
@wwylele wwylele force-pushed the simplex-face-interior branch from 8d1abcd to a206595 Compare February 15, 2026 16:47
@mathlib-triage mathlib-triage Bot assigned eric-wieser and unassigned kim-em Mar 22, 2026
Comment thread Mathlib/LinearAlgebra/AffineSpace/Simplex/Basic.lean
Comment thread Mathlib/LinearAlgebra/AffineSpace/Simplex/Basic.lean Outdated
Comment thread Mathlib/LinearAlgebra/AffineSpace/Simplex/Basic.lean
Comment thread Mathlib/LinearAlgebra/AffineSpace/Simplex/Basic.lean
@wwylele wwylele requested a review from eric-wieser April 14, 2026 03:32
@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Apr 15, 2026

@eric-wieser Does this look good now?

Comment thread Mathlib/LinearAlgebra/AffineSpace/Simplex/Basic.lean Outdated
Comment thread Mathlib/LinearAlgebra/AffineSpace/Simplex/Basic.lean Outdated
@wwylele wwylele force-pushed the simplex-face-interior branch from a896124 to 40d5b02 Compare April 18, 2026 00:01
@wwylele wwylele requested a review from eric-wieser April 22, 2026 01:05
@wwylele wwylele changed the title feat(LinearAlgebra/Simplex): closedInterior = interior + face.closedInterior feat(LinearAlgebra/Simplex): lemma for subset/disjoint relation between interior of simplex and its faces Apr 25, 2026
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Apr 27, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Apr 27, 2026
…en interior of simplex and its faces (#35365)

Intermediate lemma towards #34826. This will be used to show the measure on `interior` and `closedInterior` are equal, as the difference is a zero-measure set.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 27, 2026

Build failed (retrying...):

mathlib-bors Bot pushed a commit that referenced this pull request Apr 27, 2026
…en interior of simplex and its faces (#35365)

Intermediate lemma towards #34826. This will be used to show the measure on `interior` and `closedInterior` are equal, as the difference is a zero-measure set.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 27, 2026

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors Bot pushed a commit that referenced this pull request Apr 27, 2026
…en interior of simplex and its faces (#35365)

Intermediate lemma towards #34826. This will be used to show the measure on `interior` and `closedInterior` are equal, as the difference is a zero-measure set.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 27, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(LinearAlgebra/Simplex): lemma for subset/disjoint relation between interior of simplex and its faces [Merged by Bors] - feat(LinearAlgebra/Simplex): lemma for subset/disjoint relation between interior of simplex and its faces Apr 27, 2026
@mathlib-bors mathlib-bors Bot closed this Apr 27, 2026
@wwylele wwylele deleted the simplex-face-interior branch April 27, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants