feat(Geometry/Euclidean): Simplex.closedInterior is closed#35358
feat(Geometry/Euclidean): Simplex.closedInterior is closed#35358wwylele wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary 99884c2730Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
There was a problem hiding this comment.
Pull request overview
This pull request adds two theorems about the closed interior of simplices in Euclidean spaces, serving as an intermediate step towards calculating the volume of a simplex (PR #34826).
Changes:
- Proves that the closed interior of a simplex equals the convex hull of its vertices
- Establishes that the closed interior of a simplex is a closed set
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Does it really need |
|
I don't think either of the lemmas belongs in this file since they aren't specifically Euclidean. |
|
Right now the theorem that requires ℝ is Set.Finite.isClosed_convexHull, but I agree that this likely can be generalized. I'll look into it but this starts going into general topology that I am not good at. Please let me know if you have ideas for how to approach this. |
|
Did some preliminary research. The current dependency chain is like this
All of these are currently stated for ℝ and potentially generalizable, with some caveats
So I guess with the new approach I'll need to set up direct mapping between stdSimplex and Simplex |
|
The map between |
Intermediate lemma towards #34826. The immediate follow up is that the closed interior is measurable, but I'll leave it till the Measure folder appears under Geometry/Euclidean.
Not sure if this is the best place to put
isClosed_closedInterior. It is a bit more general than other lemmas in the file (it needs minimal topological space assumptions instead of inner product space), but it still requiresℝso I don't think it should be in the Topology folder.