Skip to content

[Merged by Bors] - feat(LinearAlgebra/AffineSpace): more lemma about simplex face and interior#34858

Closed
wwylele wants to merge 3 commits intoleanprover-community:masterfrom
wwylele:interior-restrict
Closed

[Merged by Bors] - feat(LinearAlgebra/AffineSpace): more lemma about simplex face and interior#34858
wwylele wants to merge 3 commits intoleanprover-community:masterfrom
wwylele:interior-restrict

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented Feb 5, 2026

Some intermediate lemma towards #34826


Open in Gitpod

@wwylele wwylele requested a review from Copilot February 5, 2026 00:36
@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2026

PR summary 1321470619

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ affineSpan_faceOpposite_le
+ affineSpan_face_le
+ closedInterior_map
+ closedInterior_restrict
+ faceOpposite_restrict
+ face_restrict
+ interior_map
+ interior_restrict
+ points_mem_affineSpan_face
+ points_mem_affineSpan_faceOpposite
+ points_notMem_affineSpan_faceOpposite
+ setInterior_map
+ setInterior_restrict

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds intermediate lemmas about simplex faces and interiors that support work towards computing the volume of simplices (PR #34826). The changes introduce lemmas about affine spans of faces, membership properties, and how restriction to affine subspaces interacts with faces and interiors.

Changes:

  • Added lemmas characterizing affine spans of simplex faces and opposite faces
  • Added lemmas about membership of points in affine spans of faces
  • Added lemmas showing that face operations commute with restriction to affine subspaces
  • Added lemmas showing that interior operations commute with restriction to affine subspaces

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Mathlib/LinearAlgebra/AffineSpace/Simplex/Basic.lean
@wwylele wwylele requested a review from jsm28 February 5, 2026 02:43
Comment thread Mathlib/LinearAlgebra/AffineSpace/Simplex/Basic.lean
@wwylele wwylele requested a review from jsm28 February 7, 2026 17:38
@jsm28
Copy link
Copy Markdown
Contributor

jsm28 commented Feb 7, 2026

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 7, 2026

🚀 Pull request has been placed on the maintainer queue by jsm28.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 7, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Feb 15, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Feb 15, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Feb 15, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(LinearAlgebra/AffineSpace): more lemma about simplex face and interior [Merged by Bors] - feat(LinearAlgebra/AffineSpace): more lemma about simplex face and interior Feb 15, 2026
@mathlib-bors mathlib-bors Bot closed this Feb 15, 2026
Maldooor pushed a commit to Maldooor/mathlib4 that referenced this pull request Feb 25, 2026
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants