refactor(poseidon): use native Pydantic field constraints#815
Merged
tcoratger merged 1 commit intoJun 1, 2026
Merged
Conversation
Move PoseidonParams field descriptions into attribute docstrings, matching the convention used elsewhere in the codebase. Replace the rounds_f even-count field validator with the native multiple_of=2 constraint, preserving the rationale in the field docstring and dropping the now-unused field_validator import. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tidies up
PoseidonParamsto follow the codebase's existing conventions and lean on Pydantic's native field constraints instead of a custom validator.Field(description=...)text into attribute docstrings, matching the docstring-after-field convention used elsewhere (e.g. thePoseidonclass right below it).rounds_feven-countfield_validatorwith the nativemultiple_of=2constraint. The validation constraints (gt,ge,min_length) are preserved on the fields.field_validatorimport.Notes
The native
multiple_oferror message ("Input should be a multiple of 2") is less domain-specific than the old custom message. The test was updated accordingly. All other validators in the codebase were reviewed and genuinely can't move to native constraints — they're either input coercion (mode="before"), dynamic per-subclass bounds (cls.LENGTH/cls.LIMIT), or cross-field relationships.Testing
just checkpasses (lint, format, typecheck, spell, mdformat).uv run pytest tests/lean_spec/spec/crypto/test_poseidon.py— 18 passed.🤖 Generated with Claude Code