Skip to content

ldproxy extent handling#511

Open
PZahnen wants to merge 10 commits into
masterfrom
ldp-94-ldproxy-extent-handling
Open

ldproxy extent handling#511
PZahnen wants to merge 10 commits into
masterfrom
ldp-94-ldproxy-extent-handling

Conversation

@PZahnen
Copy link
Copy Markdown
Contributor

@PZahnen PZahnen commented May 21, 2026

No description provided.

@PZahnen PZahnen requested a review from azahnen May 21, 2026 16:54
Copy link
Copy Markdown
Collaborator

@azahnen azahnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • TemporalExtent
    • should be UTC ISO datetime (YYYY-MM-DDTHH:mm:ss.sssZ)
    • use DateTimeFormatter.ISO_INSTANT.parse to validate
    • add methods for start and end (@Value.Derived, @JsonIgnore) that return Instant (Instant.from(DateTimeFormatter.ISO_INSTANT.parse))
  • SpatialExtent
    • toBoundingBox should be moved here with nativeCrs as parameter
  • FeatureProvider*
    • it seems there is a lot of duplicated code, move to AbstractFeatureProvider where appropiate

@PZahnen
Copy link
Copy Markdown
Contributor Author

PZahnen commented May 22, 2026

Thanks, should be taken care of now.

@PZahnen PZahnen requested a review from azahnen May 26, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants