Fix #5116 - Skip the sematics checks of compiler-generated functions and template instances in dcompute#5131
Open
gulugulubing wants to merge 2 commits into
Open
Fix #5116 - Skip the sematics checks of compiler-generated functions and template instances in dcompute#5131gulugulubing wants to merge 2 commits into
gulugulubing wants to merge 2 commits into
Conversation
|
|
||
| // Skip compiler-generated struct support functions (e.g. __xopEquals, | ||
| // __xopCmp, postblit, destructor). Their bodies may reference non-@compute | ||
| // templates (such as __equals for static array comparison) that are outside |
Contributor
There was a problem hiding this comment.
__equals is a template which is specifically allowed, any non-template code it generates will still cause problems though.
Contributor
Author
There was a problem hiding this comment.
Are you suggesting that __equals (and its generated code, like isEqual) should be included in isNonComputeCallExpVaild similar to dcReflect, rather than using the module-based check in visit(TemplateInstance *)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is related to #5116 and #5100.
Shared!(float[N]) tile;is actually a struct with static array, DMD's semantic analysis automatically generates support functions for such structs, and those functions drag in template instantiations fromnon-@computemodules, which triggers both the error message and the crash of compiler.