Skip to content

Conversation

@cyphermox
Copy link
Contributor

Signed-off-by: Mathieu Trudel-Lapierre mathieu.trudel-lapierre@canonical.com

Mathieu Trudel-Lapierre and others added 4 commits May 23, 2014 09:34
…vailable.

Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
… properties

Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
UrfArbitrator: allow the arbitrator to continue if /dev/rfkill is unavailable
UrfDeviceOfono: Online the modem if Powered when initially retrieving properties
@lcp
Copy link
Owner

lcp commented May 26, 2014

I don't get it. The patch seems not changing anything...

@cyphermox
Copy link
Contributor Author

Indeed, looking more into it it's missing pieces.

Mathieu Trudel-Lapierre added 5 commits May 27, 2014 08:58
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
QEMU devices don't necessarily have obvious key control devices
available from udev; avoid failing to start urfkill there just because
the input controls don't start.

Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
QEMU devices don't necessarily have obvious key control devices
available from udev; avoid failing to start urfkill there just because
the input controls don't start.

Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
@lcp
Copy link
Owner

lcp commented Nov 11, 2014

Sorry for my late reply. I didn't notice the new commits.
The QEMU profile looks fine.
I have concern about the UrfArbitrator patch. Since the rest of the code are based on the assumption that priv-fd is valid, the changes in urf_arbitrator_startup() seems not enough. For example, set_block() and finalize() will access priv->fd and this may cause problems. Could you handle those cases if necessary?

@cyphermox
Copy link
Contributor Author

On Mon, Nov 10, 2014 at 10:53 PM, Gary Ching-Pang Lin <
notifications@github.com> wrote:

Sorry for my late reply. I didn't notice the new commits.
The QEMU profile looks fine.
I have concern about the UrfArbitrator patch. Since the rest of the code
are based on the assumption that priv-fd is valid, the changes in
urf_arbitrator_startup() seems not enough. For example, set_block() and
finalize() will access priv->fd and this may cause problems. Could you
handle those cases if necessary?

I'll actually resubmit this after a bit of rework, there are some changes
and bug fixes coming in from other collaborators.

Mathieu Trudel-Lapierre mathieu.tl@gmail.com
Freenode: cyphermox, Jabber: mathieu.tl@gmail.com
4096R/EE018C93 1967 8F7D 03A1 8F38 732E FF82 C126 33E1 EE01 8C93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants