Fix InfoOutlined export to include Icon suffix#1557
Draft
rishiraj38 wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames the InfoOutlined export to InfoOutlinedIcon in the src/icons/InfoOutlined/index.ts file. The review feedback highlights that this is a breaking change and suggests adding an alias to maintain backward compatibility for components currently importing the icon.
| @@ -1 +1 @@ | |||
| export { default as InfoOutlined } from './InfoOutlined'; | |||
| export { default as InfoOutlinedIcon } from './InfoOutlined'; | |||
Contributor
There was a problem hiding this comment.
Renaming the export from InfoOutlined to InfoOutlinedIcon is a breaking change. Any components currently importing InfoOutlined from this module or through the main icons entry point will fail to build. If this icon is used in other parts of the application that are not updated in this PR, consider providing an alias to maintain backward compatibility during the transition.
Suggested change
| export { default as InfoOutlinedIcon } from './InfoOutlined'; | |
| export { default as InfoOutlinedIcon, default as InfoOutlined } from './InfoOutlined'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes an issue with the registry page in Meshery.
Signed commits