-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: use embedded Kanvas design for Meshery architecture diagram #7731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shteypandey28-hue
wants to merge
7
commits into
layer5io:master
Choose a base branch
from
shteypandey28-hue:feature/meshery-architecture-embed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+229
−9
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
efd5cb0
feat: embed Kanvas design for Meshery architecture
shteypandey28-hue a4ed64b
feat: use user's exported Kanvas design
shteypandey28-hue fabdfd7
fix: resolve module and DOM timing issues in Kanvas export script
shteypandey28-hue 7f12d53
fix: auto-fit cytoscape graph to view
shteypandey28-hue a1be3b6
fix: move kanvas embed script to static directory for serving
shteypandey28-hue 9f9487d
fix: use absolute path for embed script src to prevent 404 on nested …
shteypandey28-hue ab96a77
Merge branch 'master' into feature/meshery-architecture-embed
Rajesh-Nagarajan-11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import React from "react"; | ||
| import styled from "styled-components"; | ||
| import MesheryDesignEmbed from "@layer5/meshery-design-embed"; | ||
| import { Container } from "../../../reusecore/Layout"; | ||
|
|
||
| const ArchitectureWrapper = styled.div` | ||
| margin: 4rem 0; | ||
| text-align: center; | ||
|
|
||
| h2 { | ||
| margin-bottom: 2rem; | ||
| font-weight: 700; | ||
| } | ||
|
|
||
| .embed-container { | ||
| width: 100%; | ||
| height: 600px; | ||
| border-radius: 10px; | ||
| overflow: hidden; | ||
| box-shadow: 0 4px 20px rgba(0, 0, 0, 0.1); | ||
| } | ||
| `; | ||
|
|
||
| const MesheryArchitecture = () => { | ||
| return ( | ||
| <ArchitectureWrapper> | ||
| <Container> | ||
| <h2>Meshery Architecture</h2> | ||
| <p>Interactive infrastructure design using Meshery Kanvas.</p> | ||
| <div className="embed-container"> | ||
| <MesheryDesignEmbed | ||
| embedId="embedded-design-e27d10c1-f9bd-43ce-8aff-07f55dbca142" | ||
| embedScriptSrc="/embed-test/embedded-design-meshery.js" | ||
| /> | ||
| </div> | ||
| </Container> | ||
| </ArchitectureWrapper> | ||
| ); | ||
| }; | ||
|
|
||
| export default MesheryArchitecture; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shteypandey28-hue why this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains the exported Cytoscape JSON data and layout configuration generated directly from the Meshery Kanvas Playground.
The @layer5/meshery-design-embed component requires an embedScriptSrc to dynamically render the interactive diagram. When a design is exported from Kanvas via the "Export to JS/Embed" option, it generates this file containing all the necessary base64 SVG assets, coordinates, and styling configurations.
Why it's in the /static directory: Initially, I placed this in src/assets, but the embed script dynamically injects a <script type="module" src="..."> tag at runtime. Gatsby doesn't resolve relative asset paths in injected tags during runtime, resulting in a 404 error. Placing it in the static/ directory ensures Gatsby serves it as a public asset, making it directly accessible for the embed component to fetch and render the interactive architecture diagram successfully.