fix: invalid child elements in mobile navigation#7526
Open
AbhiSahane0 wants to merge 1 commit intolayer5io:masterfrom
Open
fix: invalid child elements in mobile navigation#7526AbhiSahane0 wants to merge 1 commit intolayer5io:masterfrom
AbhiSahane0 wants to merge 1 commit intolayer5io:masterfrom
Conversation
Signed-off-by: Abhi <cloudabhi123@gmail.com>
Member
|
🚀 Preview for commit 7d62fb3 at: https://69bb6a2ba122f1a972e9f1f3--layer5.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The mobile navigation menu contains invalid nesting that violates HTML5 specifications. An unordered list (
<ul>) can only contain<li>,<script>, or elements as direct children.There are multiple
<a>tags placed as direct children of the<ul>tags rather than being wrapped inside an<li>.This PR fixes #7484
Notes for Reviewers
Please review the changes
Signed commits