fix: add duration and tags missing#1049
Open
icoderarely wants to merge 1 commit into
Open
Conversation
Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates video metadata by adding tags and duration fields across several files and correcting a typo in the duration key for the 'publish-design' video. The review feedback identifies a potential UI issue where the 'MM:SS' duration format will be incorrectly displayed with a hardcoded ' min' suffix (e.g., '0:16 min') due to existing template logic. It is recommended to either provide the duration as a numeric value in minutes or update the site templates to handle the time format correctly.
|
🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1049/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #1048 by normalizing video metadata so duration/tags render consistently across cards.
Adds/updates duration and tags for Publishing Designs, Meshery Playground Teaser, and Birth of Kanvas Logo entries.
2026-05-16.14-54-28.mp4
Signed commits