fix: add uniform elevation banners to remaining 5 admin-required pages#506
Conversation
Apply the same Surface2/green banner pattern (matching WindowsUpdateView, PrivacyView, WindowsFeaturesView, DnsHostsView, ServicesView) to: - CleanupView (replaced old orange warning banner) - SystemHealthView - PerformanceView - NetworkRepairView - AppBlockerView Each page shows a grey banner with shield icon + reason when not elevated, and a green confirmation banner when elevated. ViewModels that were missing IsElevated/RelaunchAsAdminCommand have been updated accordingly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (8)
📝 WalkthroughWalkthroughThis PR adds elevation state tracking and admin relaunch capability across the application by introducing observable ChangesElevation Status and Admin Relaunch Support
Sequence DiagramsequenceDiagram
participant App as Application
participant PerformanceVM as PerformanceViewModel
participant AdminHelper
participant View as PerformanceView
App->>PerformanceVM: InitAsync()
PerformanceVM->>AdminHelper: IsElevated()
AdminHelper-->>PerformanceVM: elevation status
PerformanceVM->>PerformanceVM: _isElevated = status
PerformanceVM-->>View: notify IsElevated property change
View->>View: render elevation banner
rect rgba(100, 200, 255, 0.5)
User->>View: click "Run as administrator"
View->>PerformanceVM: RelaunchAsAdminCommand
PerformanceVM->>AdminHelper: RelaunchAsAdmin()
AdminHelper-->>PerformanceVM: success
PerformanceVM->>App: Application.Current.Shutdown()
end
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Apply the same Surface2/green banner pattern (matching WindowsUpdateView, PrivacyView, WindowsFeaturesView, DnsHostsView, ServicesView) to: - CleanupView (replaced old orange warning banner) - SystemHealthView - PerformanceView - NetworkRepairView - AppBlockerView Each page shows a grey banner with shield icon + reason when not elevated, and a green confirmation banner when elevated. ViewModels that were missing IsElevated/RelaunchAsAdminCommand have been updated accordingly. Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
Completes uniform elevation banner coverage. All 10 admin-required pages now have identical design: grey banner with reason + blue button (not elevated), green banner with confirmation (elevated).
Summary by CodeRabbit
New Features
UI/UX Improvements