feat: Update tracing hook for semantic convention updates. #31
Conversation
| def __init__(self, options: HookOptions = HookOptions()): | ||
| self.__tracer = trace.get_tracer_provider().get_tracer("launchdarkly") | ||
| self.__options = options | ||
| if self.__options.include_variant: |
There was a problem hiding this comment.
I don't know an actually reasonable way to do this without the logger instance.
There was a problem hiding this comment.
You can just grab the logger from wherever. Python is just like that.
from logging import getLogger
logger = getLogger('launchdarkly-otel')
logger.warning('Hi there')If we document that we always use the 'launchdarkly-otel' named logger, then it makes it easy for customers to affect the formatting without having to pass a logger around everywhere.
But this honestly seems pretty reasonable to me.
…emantic-conventions
…ython-server-sdk-otel into rlamb/minimum-version-3.9
| def __init__(self, options: HookOptions = HookOptions()): | ||
| self.__tracer = trace.get_tracer_provider().get_tracer("launchdarkly") | ||
| self.__options = options | ||
| if self.__options.include_variant: |
There was a problem hiding this comment.
You can just grab the logger from wherever. Python is just like that.
from logging import getLogger
logger = getLogger('launchdarkly-otel')
logger.warning('Hi there')If we document that we always use the 'launchdarkly-otel' named logger, then it makes it easy for customers to affect the formatting without having to pass a logger around everywhere.
But this honestly seems pretty reasonable to me.
🤖 I have created a release *beep* *boop* --- ## [1.2.0](1.1.0...1.2.0) (2025-07-11) ### Features * Update tracing hook for semantic convention updates. ([#31](#31)) ([25dafad](25dafad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
No description provided.